Skip to content

Implement UseUserAccessGroup for Firebase Auth C++ SDK #1759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Implement UseUserAccessGroup for Firebase Auth C++ SDK #1759

wants to merge 1 commit into from

Conversation

jonsimantov
Copy link
Contributor

This commit introduces the UseUserAccessGroup method to the Firebase Authentication C++ SDK.

On iOS, this method wraps the [FIRAuth useUserAccessGroup:error:] Objective-C call, allowing developers to specify an iCloud keychain access group.

On other platforms (desktop, Android), this method is a no-op and returns kAuthErrorNone, as the functionality is specific to iOS.

Description

Provide details of the change, and generalize the change in the PR title above.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@google-labs-jules
Implement UseUserAccessGroup for Firebase Auth C++ SDK
1305ead 
This commit introduces the UseUserAccessGroup method to the Firebase
Authentication C++ SDK.

On iOS, this method wraps the [FIRAuth useUserAccessGroup:error:]
Objective-C call, allowing developers to specify an iCloud keychain
access group.

On other platforms (desktop, Android), this method is a no-op and
returns kAuthErrorNone, as the functionality is specific to iOS.
jonsimantov
jonsimantov commented Jun 27, 2025
View reviewed changes
Copy link
Contributor Author

@jonsimantov jonsimantov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add a very simple integraton test to auth/integration_test/src/integration_test.cc? No need to check the return values, just make sure calling it doesn't crash on all the platforms.

auth/src/desktop/auth_desktop.cc
@@ -575,6 +575,11 @@ void Auth::UseEmulator(std::string host, uint32_t port) {
auth_impl->assigned_emulator_url.append(std::to_string(port));
}

AuthError Auth::UseUserAccessGroup(const char* access_group) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There needs to be an Android version too.

@firebase firebase locked and limited conversation to collaborators Jul 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jonsimantov