-
Notifications
You must be signed in to change notification settings - Fork 124
Remove deprecated Dynamic Links library #1774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @a-maurice, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request performs a comprehensive removal of the deprecated Firebase Dynamic Links library and its associated Invites functionality. The changes span across the entire SDK, affecting core code, build systems, documentation, and testing infrastructure, ensuring a clean and complete excision of the deprecated components.
Highlights
- Core Library Removal: The Firebase Dynamic Links library, along with its associated Invites remnants, has been completely removed from the SDK. This includes all source code, headers, build configurations (CMake, Gradle), and related resources across Android, iOS, and desktop platforms.
- Build System Cleanup: Extensive modifications were made to the build system, including
CMakeLists.txt
files, Gradle dependency configurations (firebase_dependencies.gradle
,app/build.gradle
,settings.gradle
), and iOS CocoaPods (ios_pod/Podfile
), to eliminate all references and build targets for Dynamic Links and Invites. - Documentation and Testing Updates: The main
README.md
,AGENTS.md
, andrelease_build_files/readme.md
have been updated to reflect the deprecation and removal of Dynamic Links. The entire integration test suite for Dynamic Links was also removed, along with associated GitHub Actions workflows and secret management. - Codebase Simplification: Numerous files related to Dynamic Links and Invites, including JNI wrappers, internal receiver implementations, cached data handlers, and platform-specific helpers (Android, iOS, stub), were deleted, significantly reducing the codebase size and complexity.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes the deprecated Dynamic Links library. The changes are comprehensive, touching build scripts, source files, and documentation. A few inconsistencies were identified and flagged for correction to ensure consistency.
✅ Integration test succeeded!Requested by @a-maurice on commit 4acaa04 |
Description
Remove the Dynamic Links library as part of the upcoming breaking changes. Also remove remnants of Invites, since that was still around because of Dynamic Links.
Testing
Type of Change
Place an
x
the applicable box:Notes
Release Notes
section ofrelease_build_files/readme.md
.