Skip to content

Conversation

@Mooyeee
Copy link

@Mooyeee Mooyeee commented Oct 20, 2025

This PR adds support for the method signInWithProvider (from the flutter SDK) for macOS, allowing us to login with SSO on macOS platform. Tried with Microsoft AD SSO.
The proposed solution mimics the iOS one but implemented of course with AppKit.

Linked Issues:
#14990

Let me know if something looks odd :)

@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@google-cla
Copy link

google-cla bot commented Oct 20, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ncooke3 ncooke3 self-requested a review October 22, 2025 14:25
@Mooyeee
Copy link
Author

Mooyeee commented Oct 22, 2025

I've noticed some issues and fixed them :)
The issues:

  • The user closing flow wasn't correctly notified to flutter, overriding close instead of performClose fixed it
  • The first frame of the NSWindow was white until a resize; I was mistakenly creating two spinners and two webviews, creating them once fixed the issue

Also formatted the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant