Unify Pipelines and Firestore classic in CDN and g3 builds #9323

MarkDuckworth · 2025-10-15T18:34:26Z

For CDN and G3 builds, we will output two bundles:

firebase-firestore.js - includes only Firestore classic API surface
firebase-firestore-pipelines.js - includes both the Firestore classic and Firestore Pipelines API surface. The Pipelines API surface is in a namespace called (pipelines).

…ace 'pipelines'

changeset-bot · 2025-10-15T18:34:30Z

⚠️ No Changeset found

Latest commit: 637027a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2025-10-15T18:34:40Z

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v15.0

google-oss-bot · 2025-10-15T18:45:00Z

Size Report ¹

Affected Products

@firebase/firestore
Type Base (90fed2f) Merge (dda0a15) Diff
browser 393 kB 393 kB +138 B (+0.0%)
main 634 kB 636 kB +2.32 kB (+0.4%)
module 393 kB 393 kB +138 B (+0.0%)
react-native 393 kB 393 kB +138 B (+0.0%)
@firebase/firestore-lite
Type Base (90fed2f) Merge (dda0a15) Diff
browser 118 kB 118 kB +134 B (+0.1%)
main 169 kB 169 kB +182 B (+0.1%)
module 118 kB 118 kB +134 B (+0.1%)
react-native 118 kB 118 kB +134 B (+0.1%)
@firebase/firestore-lite-pipelines
Type Base (90fed2f) Merge (dda0a15) Diff
browser 108 kB 108 kB +134 B (+0.1%)
main 207 kB 207 kB +182 B (+0.1%)
module 108 kB 108 kB +134 B (+0.1%)
react-native 108 kB 109 kB +134 B (+0.1%)
@firebase/firestore-pipelines
Type Base (90fed2f) Merge (dda0a15) Diff
browser 203 kB 203 kB +312 B (+0.2%)
main 630 kB 631 kB +866 B (+0.1%)
module 203 kB 203 kB +312 B (+0.2%)
react-native 203 kB 203 kB +312 B (+0.2%)

`bundle`

16 size changes

Type	Base (`90fed2f`)	Merge (`dda0a15`)	Diff
firestore (CSI Auto Indexing Disable and Delete)	282 kB	282 kB	+138 B (+0.0%)
firestore (CSI Auto Indexing Enable)	282 kB	282 kB	+138 B (+0.0%)
firestore (Persistence)	314 kB	314 kB	+138 B (+0.0%)
firestore (Pipeline Query with lt filter (execute))	240 kB	240 kB	+144 B (+0.1%)
firestore (Query Cursors)	254 kB	254 kB	+138 B (+0.1%)
firestore (Query)	251 kB	251 kB	+138 B (+0.1%)
firestore (Read data once)	240 kB	241 kB	+138 B (+0.1%)
firestore (Read Write w Persistence)	334 kB	334 kB	+138 B (+0.0%)
firestore (Realtime updates)	241 kB	241 kB	+138 B (+0.1%)
firestore (Transaction)	220 kB	220 kB	+138 B (+0.1%)
firestore (Write data)	221 kB	221 kB	+138 B (+0.1%)
firestore-lite (Query Cursors)	108 kB	108 kB	+134 B (+0.1%)
firestore-lite (Query)	104 kB	104 kB	+134 B (+0.1%)
firestore-lite (Read data once)	78.5 kB	78.6 kB	+134 B (+0.2%)
firestore-lite (Transaction)	105 kB	105 kB	+134 B (+0.1%)
firestore-lite (Write data)	88.5 kB	88.7 kB	+134 B (+0.2%)

`firebase`

Type	Base (`90fed2f`)	Merge (`dda0a15`)	Diff
firebase-compat.js	806 kB	806 kB	+132 B (+0.0%)
firebase-firestore-compat.js	344 kB	344 kB	+132 B (+0.0%)
firebase-firestore-lite-pipelines.js	?	120 kB	? (?)
firebase-firestore-lite.js	135 kB	135 kB	+134 B (+0.1%)
firebase-firestore-pipelines.js	258 kB	500 kB	+242 kB (+93.5%)
firebase-firestore.js	450 kB	450 kB	+138 B (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/VGUHwDMEDw.html

google-oss-bot · 2025-10-15T18:56:57Z

Size Analysis Report ¹

Affected Products

@firebase/firestore
- _internalAggregationQueryToProtoRunAggregationQueryRequest
  Size
  Type Base (90fed2f) Merge (dda0a15) Diff
  size 48.8 kB 48.8 kB +45 B (+0.1%)
  size-with-ext-deps 117 kB 118 kB +45 B (+0.0%)
- _internalQueryToProtoQueryTarget
  Size
  Type Base (90fed2f) Merge (dda0a15) Diff
  size 55.5 kB 55.5 kB +45 B (+0.1%)
  size-with-ext-deps 124 kB 124 kB +45 B (+0.0%)
- addDoc
  Size
  Type Base (90fed2f) Merge (dda0a15) Diff
  size 141 kB 141 kB +138 B (+0.1%)
  size-with-ext-deps 212 kB 212 kB +138 B (+0.1%)
- deleteAllPersistentCacheIndexes
  Size
  Type Base (90fed2f) Merge (dda0a15) Diff
  size 107 kB 107 kB +45 B (+0.0%)
  size-with-ext-deps 177 kB 177 kB +45 B (+0.0%)
- deleteDoc
  Size
  Type Base (90fed2f) Merge (dda0a15) Diff
  size 134 kB 134 kB +138 B (+0.1%)
  size-with-ext-deps 205 kB 205 kB +138 B (+0.1%)
- disableNetwork
  Size
  Type Base (90fed2f) Merge (dda0a15) Diff
  size 123 kB 123 kB +138 B (+0.1%)
  size-with-ext-deps 193 kB 193 kB +138 B (+0.1%)
- disablePersistentCacheIndexAutoCreation
  Size
  Type Base (90fed2f) Merge (dda0a15) Diff
  size 107 kB 107 kB +45 B (+0.0%)
  size-with-ext-deps 177 kB 177 kB +45 B (+0.0%)
- enableIndexedDbPersistence
  Size
  Type Base (90fed2f) Merge (dda0a15) Diff
  size 198 kB 198 kB +138 B (+0.1%)
  size-with-ext-deps 269 kB 269 kB +138 B (+0.1%)
- enableMultiTabIndexedDbPersistence
  Size
  Type Base (90fed2f) Merge (dda0a15) Diff
  size 235 kB 235 kB +138 B (+0.1%)
  size-with-ext-deps 305 kB 305 kB +138 B (+0.0%)
- enableNetwork
  Size
  Type Base (90fed2f) Merge (dda0a15) Diff
  size 123 kB 123 kB +138 B (+0.1%)
  size-with-ext-deps 193 kB 193 kB +138 B (+0.1%)
- enablePersistentCacheIndexAutoCreation
  Size
  Type Base (90fed2f) Merge (dda0a15) Diff
  size 107 kB 107 kB +45 B (+0.0%)
  size-with-ext-deps 177 kB 177 kB +45 B (+0.0%)
- ensureFirestoreConfigured
  Size
  Type Base (90fed2f) Merge (dda0a15) Diff
  size 36.0 kB 36.1 kB +45 B (+0.1%)
  size-with-ext-deps 105 kB 105 kB +45 B (+0.0%)
- executeWrite
  Size
  Type Base (90fed2f) Merge (dda0a15) Diff
  size 133 kB 134 kB +138 B (+0.1%)
  size-with-ext-deps 204 kB 204 kB +138 B (+0.1%)
- getAggregateFromServer
  Size
  Type Base (90fed2f) Merge (dda0a15) Diff
  size 128 kB 128 kB +138 B (+0.1%)
  size-with-ext-deps 199 kB 199 kB +138 B (+0.1%)
- getCountFromServer
  Size
  Type Base (90fed2f) Merge (dda0a15) Diff
  size 128 kB 129 kB +138 B (+0.1%)
  size-with-ext-deps 199 kB 199 kB +138 B (+0.1%)
- getDoc
  Size
  Type Base (90fed2f) Merge (dda0a15) Diff
  size 161 kB 161 kB +138 B (+0.1%)
  size-with-ext-deps 231 kB 231 kB +138 B (+0.1%)
- getDocFromCache
  Size
  Type Base (90fed2f) Merge (dda0a15) Diff
  size 110 kB 110 kB +45 B (+0.0%)
  size-with-ext-deps 180 kB 180 kB +45 B (+0.0%)
- getDocFromServer
  Size
  Type Base (90fed2f) Merge (dda0a15) Diff
  size 161 kB 161 kB +138 B (+0.1%)
  size-with-ext-deps 231 kB 231 kB +138 B (+0.1%)
- getDocs
  Size
  Type Base (90fed2f) Merge (dda0a15) Diff
  size 161 kB 161 kB +138 B (+0.1%)
  size-with-ext-deps 231 kB 231 kB +138 B (+0.1%)
- getDocsFromCache
  Size
  Type Base (90fed2f) Merge (dda0a15) Diff
  size 116 kB 116 kB +45 B (+0.0%)
  size-with-ext-deps 186 kB 186 kB +45 B (+0.0%)
- getDocsFromServer
  Size
  Type Base (90fed2f) Merge (dda0a15) Diff
  size 160 kB 160 kB +138 B (+0.1%)
  size-with-ext-deps 231 kB 231 kB +138 B (+0.1%)
- getPersistentCacheIndexManager
  Size
  Type Base (90fed2f) Merge (dda0a15) Diff
  size 37.1 kB 37.2 kB +45 B (+0.1%)
  size-with-ext-deps 106 kB 106 kB +45 B (+0.0%)
- loadBundle
  Size
  Type Base (90fed2f) Merge (dda0a15) Diff
  size 132 kB 132 kB +138 B (+0.1%)
  size-with-ext-deps 203 kB 203 kB +138 B (+0.1%)
- memoryLocalCache
  Size
  Type Base (90fed2f) Merge (dda0a15) Diff
  size 117 kB 117 kB +93 B (+0.1%)
  size-with-ext-deps 188 kB 188 kB +93 B (+0.0%)
- namedQuery
  Size
  Type Base (90fed2f) Merge (dda0a15) Diff
  size 108 kB 108 kB +45 B (+0.0%)
  size-with-ext-deps 178 kB 178 kB +45 B (+0.0%)
- onSnapshot
  Size
  Type Base (90fed2f) Merge (dda0a15) Diff
  size 161 kB 161 kB +138 B (+0.1%)
  size-with-ext-deps 232 kB 232 kB +138 B (+0.1%)
- onSnapshotResume
  Size
  Type Base (90fed2f) Merge (dda0a15) Diff
  size 170 kB 170 kB +138 B (+0.1%)
  size-with-ext-deps 241 kB 241 kB +138 B (+0.1%)
- onSnapshotsInSync
  Size
  Type Base (90fed2f) Merge (dda0a15) Diff
  size 156 kB 156 kB +138 B (+0.1%)
  size-with-ext-deps 227 kB 227 kB +138 B (+0.1%)
- persistentLocalCache
  Size
  Type Base (90fed2f) Merge (dda0a15) Diff
  size 195 kB 195 kB +93 B (+0.0%)
  size-with-ext-deps 265 kB 265 kB +93 B (+0.0%)
- persistentMultipleTabManager
  Size
  Type Base (90fed2f) Merge (dda0a15) Diff
  size 231 kB 231 kB +93 B (+0.0%)
  size-with-ext-deps 302 kB 302 kB +93 B (+0.0%)
- persistentSingleTabManager
  Size
  Type Base (90fed2f) Merge (dda0a15) Diff
  size 194 kB 194 kB +93 B (+0.0%)
  size-with-ext-deps 265 kB 265 kB +93 B (+0.0%)
- runTransaction
  Size
  Type Base (90fed2f) Merge (dda0a15) Diff
  size 140 kB 140 kB +138 B (+0.1%)
  size-with-ext-deps 210 kB 211 kB +138 B (+0.1%)
- setDoc
  Size
  Type Base (90fed2f) Merge (dda0a15) Diff
  size 140 kB 140 kB +138 B (+0.1%)
  size-with-ext-deps 211 kB 211 kB +138 B (+0.1%)
- setIndexConfiguration
  Size
  Type Base (90fed2f) Merge (dda0a15) Diff
  size 109 kB 109 kB +45 B (+0.0%)
  size-with-ext-deps 179 kB 180 kB +45 B (+0.0%)
- updateDoc
  Size
  Type Base (90fed2f) Merge (dda0a15) Diff
  size 141 kB 141 kB +138 B (+0.1%)
  size-with-ext-deps 211 kB 212 kB +138 B (+0.1%)
- waitForPendingWrites
  Size
  Type Base (90fed2f) Merge (dda0a15) Diff
  size 123 kB 123 kB +138 B (+0.1%)
  size-with-ext-deps 194 kB 194 kB +138 B (+0.1%)
- writeBatch
  Size
  Type Base (90fed2f) Merge (dda0a15) Diff
  size 143 kB 143 kB +138 B (+0.1%)
  size-with-ext-deps 213 kB 214 kB +138 B (+0.1%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/JJv1Pvc6cc.html

…ebase-firestore.js file

…t firebase-firestore-pipelines.js contains both classic and pipelines APIs.

… cdn.ts to packages/firebase/firestore/pipelines

…wser unit testing.

dlarocque · 2025-10-22T13:23:03Z

packages/firestore/rollup.config.js

-      })
+      }),
+
+      declareModuleReplacePlugin()


It's not obvious why this plugin is necessary. Can you add comments explaining the problem this solves?

dlarocque · 2025-10-22T13:24:09Z

packages/firestore/rollup.config.js

+  // The regex we created earlier
+  const moduleToReplace =
+    /declare module '\.\/\S+' \{\s+interface Firestore \{\s+pipeline\(\): PipelineSource<Pipeline>;\s+}\s*}/gm;
+
+  // What to replace it with (an empty string to remove it)


These comments seem out of date. Can you update them?

dlarocque · 2025-10-22T13:25:23Z

packages/firestore/rollup.config.js

 ];

+// TODO - update the implementation to match all content in the declare module block.
+function declareModuleReplacePlugin() {


All our custom rollup plugins exist in scripts/build. Can you move this plugin to a new file in that directory?

dlarocque · 2025-10-22T13:28:42Z

packages/firestore/src/core/firestore_client.ts

    public asyncQueue: AsyncQueue,
-    private databaseInfo: DatabaseInfo,
+    /**
+     * @internal


I don't think @internal is necessary here, since FirestoreClient is not a public API.

dist/firestore/src/global_index.d.ts now includes pipelines in namesp…

a11ea79

…ace 'pipelines'

MarkDuckworth requested review from a team as code owners October 15, 2025 18:34

MarkDuckworth added 3 commits October 15, 2025 14:10

Update global.ts

d175049

Custom replacer plugin to remove declare module block from global.d.ts

5fb6ebe

Update CDN and g3 builds of Firestore to include Pipelines in the fir…

d705208

…ebase-firestore.js file

MarkDuckworth changed the title ~~firestore globals fix for console~~ Unify Pipelines and Firestore classic for G3 import Oct 16, 2025

MarkDuckworth assigned MarkDuckworth and dlarocque and unassigned MarkDuckworth Oct 16, 2025

MarkDuckworth added 4 commits October 16, 2025 14:49

Updated CDN bundles so that firebase-firestore.js is not modified, bu…

31535d9

…t firebase-firestore-pipelines.js contains both classic and pipelines APIs.

Fix regression in _internalPipelineToExecutePipelineRequestProto

a78b761

Fixing missing paths in package.json

cdfc931

Fix binary size script

54a17c6

MarkDuckworth changed the title ~~Unify Pipelines and Firestore classic for G3 import~~ Unify Pipelines and Firestore classic in CDN and g3 builds Oct 17, 2025

MarkDuckworth added 3 commits October 17, 2025 15:43

Add support for index.cdn.ts files in packages/firebase. Then added a…

81698f9

… cdn.ts to packages/firebase/firestore/pipelines

send api key to DBE requests (#9331)

6251400

Rename grpc_connection.node.test.ts, so the file is filtered from bro…

637027a

…wser unit testing.

dlarocque reviewed Oct 22, 2025

View reviewed changes

Unify Pipelines and Firestore classic in CDN and g3 builds #9323

Are you sure you want to change the base?

Unify Pipelines and Firestore classic in CDN and g3 builds #9323

Uh oh!

Conversation

MarkDuckworth commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions bot commented Oct 15, 2025

Vertex AI Mock Responses Check ⚠️

Uh oh!

google-oss-bot commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report 1

Affected Products

@firebase/firestore

@firebase/firestore-lite

@firebase/firestore-lite-pipelines

@firebase/firestore-pipelines

bundle

firebase

Test Logs

Uh oh!

google-oss-bot commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Analysis Report 1

Affected Products

@firebase/firestore

_internalAggregationQueryToProtoRunAggregationQueryRequest

_internalQueryToProtoQueryTarget

addDoc

deleteAllPersistentCacheIndexes

deleteDoc

disableNetwork

disablePersistentCacheIndexAutoCreation

enableIndexedDbPersistence

enableMultiTabIndexedDbPersistence

enableNetwork

enablePersistentCacheIndexAutoCreation

ensureFirestoreConfigured

executeWrite

getAggregateFromServer

getCountFromServer

getDoc

getDocFromCache

getDocFromServer

getDocs

getDocsFromCache

getDocsFromServer

getPersistentCacheIndexManager

loadBundle

memoryLocalCache

namedQuery

onSnapshot

onSnapshotResume

onSnapshotsInSync

persistentLocalCache

persistentMultipleTabManager

persistentSingleTabManager

runTransaction

setDoc

setIndexConfiguration

updateDoc

waitForPendingWrites

writeBatch

Test Logs

Uh oh!

dlarocque Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

dlarocque Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

dlarocque Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

MarkDuckworth commented Oct 15, 2025 •

edited

Loading

changeset-bot bot commented Oct 15, 2025 •

edited

Loading

google-oss-bot commented Oct 15, 2025 •

edited

Loading

Size Report ¹

`@firebase/firestore`

`@firebase/firestore-lite`

`@firebase/firestore-lite-pipelines`

`@firebase/firestore-pipelines`

`bundle`

`firebase`

google-oss-bot commented Oct 15, 2025 •

edited

Loading

Size Analysis Report ¹

`@firebase/firestore`

`_internalAggregationQueryToProtoRunAggregationQueryRequest`

`_internalQueryToProtoQueryTarget`

`addDoc`

`deleteAllPersistentCacheIndexes`

`deleteDoc`

`disableNetwork`

`disablePersistentCacheIndexAutoCreation`

`enableIndexedDbPersistence`

`enableMultiTabIndexedDbPersistence`

`enableNetwork`

`enablePersistentCacheIndexAutoCreation`

`ensureFirestoreConfigured`

`executeWrite`

`getAggregateFromServer`

`getCountFromServer`

`getDoc`

`getDocFromCache`

`getDocFromServer`

`getDocs`

`getDocsFromCache`

`getDocsFromServer`

`getPersistentCacheIndexManager`

`loadBundle`

`memoryLocalCache`

`namedQuery`

`onSnapshot`

`onSnapshotResume`

`onSnapshotsInSync`

`persistentLocalCache`

`persistentMultipleTabManager`

`persistentSingleTabManager`

`runTransaction`

`setDoc`

`setIndexConfiguration`

`updateDoc`

`waitForPendingWrites`

`writeBatch`