Skip to content

Conversation

@athiramanu
Copy link

Bug 1: Experiments are never set as UP if analytics connection fails
eg:
IndexedDB: exp_1, exp_2
Fetch response: { exp_1: 1, exp_2: 0, exp_3: 1}
Diff result: {exp_3}
IndexedDB updated to exp_1, exp_2, exp_3

in this scenario if setUserProperty was not called, exp_3 will never come in the diff result and hence the experiment will not be set on GA

Fix: Skip the diff call and always send the entire list

Bug 2: gtag does not set user property until a logEvent call occurs

Fix: After setting UP ABT will log an event that ABT was updated

@athiramanu athiramanu requested review from a team and erikeldridge as code owners October 17, 2025 13:20
@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2025

⚠️ No Changeset found

Latest commit: 88d0a1c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v15.0

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 17, 2025

Size Report 1

Affected Products

  • @firebase/remote-config

    TypeBase (b5f96dd)Merge (553b9d0)Diff
    browser41.5 kB41.4 kB-34 B (-0.1%)
    main42.7 kB42.6 kB-34 B (-0.1%)
    module41.5 kB41.4 kB-34 B (-0.1%)
  • bundle

    TypeBase (b5f96dd)Merge (553b9d0)Diff
    remote-config (getAndFetch)60.9 kB60.9 kB+38 B (+0.1%)
  • firebase

    TypeBase (b5f96dd)Merge (553b9d0)Diff
    firebase-compat.js811 kB811 kB+39 B (+0.0%)
    firebase-remote-config-compat.js40.1 kB40.1 kB+39 B (+0.1%)
    firebase-remote-config.js45.0 kB45.0 kB+43 B (+0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/e0D86lLdpt.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 17, 2025

Size Analysis Report 1

Affected Products

  • @firebase/remote-config

    • activate

      Size

      TypeBase (b5f96dd)Merge (553b9d0)Diff
      size25.0 kB25.0 kB+38 B (+0.2%)
      size-with-ext-deps51.5 kB51.5 kB+38 B (+0.1%)
    • fetchAndActivate

      Size

      TypeBase (b5f96dd)Merge (553b9d0)Diff
      size25.6 kB25.7 kB+38 B (+0.1%)
      size-with-ext-deps52.1 kB52.2 kB+38 B (+0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/haA1cLHCkB.html

const analytics = this.analyticsProvider.getImmediate({ optional: true });
if (analytics) {
analytics.setUserProperties({ properties: customProperty });
analytics.logEvent(`Received ABT experiment update`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are event names allowed to have spaces? I think it might be safer to use "set_firebase_experiment_state" as Sam suggested.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@athiramanu athiramanu merged commit 851a47f into web-experiment Oct 25, 2025
34 checks passed
@athiramanu athiramanu deleted the web-exp-bugfix branch October 25, 2025 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants