-
Notifications
You must be signed in to change notification settings - Fork 982
Fix feature defects if Web Experiments #9327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Vertex AI Mock Responses Check
|
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
| const analytics = this.analyticsProvider.getImmediate({ optional: true }); | ||
| if (analytics) { | ||
| analytics.setUserProperties({ properties: customProperty }); | ||
| analytics.logEvent(`Received ABT experiment update`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are event names allowed to have spaces? I think it might be safer to use "set_firebase_experiment_state" as Sam suggested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Bug 1: Experiments are never set as UP if analytics connection fails
eg:
IndexedDB: exp_1, exp_2
Fetch response: { exp_1: 1, exp_2: 0, exp_3: 1}
Diff result: {exp_3}
IndexedDB updated to exp_1, exp_2, exp_3
in this scenario if setUserProperty was not called, exp_3 will never come in the diff result and hence the experiment will not be set on GA
Fix: Skip the diff call and always send the entire list
Bug 2: gtag does not set user property until a logEvent call occurs
Fix: After setting UP ABT will log an event that ABT was updated