Skip to content

Conversation

hlshen
Copy link
Contributor

@hlshen hlshen commented Jun 11, 2025

Prevents Codelens from flickering while typing.


vscode.window.onDidChangeActiveTextEditor((editor) => {
if (editor) {
this.document = editor.document;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this parse non-graphql documents too?

Copy link
Contributor

@joehan joehan Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope - this code implements the code lens provider but does not register it. We tell vscode what files to apply this for when we register it (see src/dataconnect/index.ts)

Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


vscode.window.onDidChangeActiveTextEditor((editor) => {
if (editor) {
this.document = editor.document;
Copy link
Contributor

@joehan joehan Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope - this code implements the code lens provider but does not register it. We tell vscode what files to apply this for when we register it (see src/dataconnect/index.ts)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants