-
Notifications
You must be signed in to change notification settings - Fork 1k
docs: sync framework docs from internal repo #8861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+26
−12
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,6 +15,14 @@ to Firebase and serve dynamic content to your users. | |
|
||
<<_includes/_preview-disclaimer.md>> | ||
|
||
Caution: For developers creating a full-stack Angular app, we strongly | ||
recommend [Firebase App Hosting](/docs/app-hosting/). | ||
If you're already using the frameworks experiment in the Firebase CLI, we | ||
recommend "graduating" to | ||
{{app_hosting}}. With {{app_hosting}}, you'll have a unified solution to manage | ||
everything from CDN to server-side rendering, along with improved GitHub | ||
integration. | ||
|
||
<<_includes/_before-you-begin.md>> | ||
|
||
- Optional: AngularFire | ||
|
@@ -55,9 +63,11 @@ To prerender dynamic content in Angular, you need to set up Angular SSR. | |
ng add @angular/ssr | ||
``` | ||
|
||
See the [Angular Prerendering (SSG) guide](https://angular.dev/guide/prerendering) | ||
See the [Angular Prerendering (SSG) guide](https://angular.dev/guide/ssr) | ||
for more information. | ||
|
||
### Optional: add a server module | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
||
#### Deploy | ||
|
||
When you deploy with `firebase deploy`, Firebase builds your browser bundle, | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -18,6 +18,14 @@ logic to {{cloud_functions_full}}. | |||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
<<_includes/_preview-disclaimer.md>> | ||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
Caution: For developers creating a full-stack Next.js app, we strongly | ||||||||||||||||||||||||||||||
recommend [Firebase App Hosting](/docs/app-hosting/). | ||||||||||||||||||||||||||||||
If you're already using the frameworks experiment in the Firebase CLI, we | ||||||||||||||||||||||||||||||
recommend "graduating" to | ||||||||||||||||||||||||||||||
{{app_hosting}}. With {{app_hosting}}, you'll have a unified solution to manage | ||||||||||||||||||||||||||||||
everything from CDN to server-side rendering, along with improved GitHub | ||||||||||||||||||||||||||||||
integration. | ||||||||||||||||||||||||||||||
Comment on lines
+21
to
+27
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The new caution message could be improved for better clarity and presentation.
Suggested change
|
||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
<<_includes/_before-you-begin.md>> | ||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
- Optional: use the experimental ReactFire library to benefit from its | ||||||||||||||||||||||||||||||
|
@@ -26,7 +34,7 @@ logic to {{cloud_functions_full}}. | |||||||||||||||||||||||||||||
<<_includes/_initialize-firebase.md>> | ||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
1. Answer yes to "Do you want to use a web framework? (experimental)" | ||||||||||||||||||||||||||||||
1. Choose your hosting source directory. If this an existing Next.js app, | ||||||||||||||||||||||||||||||
1. Choose your hosting source directory. If this is an existing Next.js app, | ||||||||||||||||||||||||||||||
the {{cli}} process completes, and you can proceed to the next section. | ||||||||||||||||||||||||||||||
1. If prompted, choose Next.js. | ||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
|
@@ -45,14 +53,14 @@ on its live site. | |||||||||||||||||||||||||||||
## Pre-render dynamic content | ||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
The {{firebase_cli}} will detect usage of | ||||||||||||||||||||||||||||||
[getStaticProps](https://nextjs.org/docs/pages/building-your-application/data-fetching/get-static-props) | ||||||||||||||||||||||||||||||
[getStaticProps](https://nextjs.org/docs/pages/building-your-application/data-fetching/get-static-props) | ||||||||||||||||||||||||||||||
and [getStaticPaths](https://nextjs.org/docs/pages/building-your-application/data-fetching/get-static-paths). | ||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
### Optional: integrate with the Firebase JS SDK | ||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
When including Firebase JS SDK methods in both server and client bundles, guard | ||||||||||||||||||||||||||||||
against runtime errors by checking `isSupported()` before using the product. | ||||||||||||||||||||||||||||||
Not all products are | ||||||||||||||||||||||||||||||
Not all products are | ||||||||||||||||||||||||||||||
[supported in all environments](/docs/web/environments-js-sdk#other_environments). | ||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
Tip: consider using | ||||||||||||||||||||||||||||||
|
@@ -69,7 +77,7 @@ and [getStaticPaths](https://nextjs.org/docs/basic-features/data-fetching/get-st | |||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
The {{firebase_cli}} will detect usage of | ||||||||||||||||||||||||||||||
[getServerSideProps](https://nextjs.org/docs/basic-features/data-fetching/get-server-side-props). | ||||||||||||||||||||||||||||||
In such cases, the {{cli}} will deploy functions to {{cloud_functions_full}} to run dynamic | ||||||||||||||||||||||||||||||
In such cases, the {{cli}} will deploy functions to {{cloud_functions_full}} to run dynamic | ||||||||||||||||||||||||||||||
server code. You can view information about these functions, such as their domain and runtime | ||||||||||||||||||||||||||||||
configuration, in the [Firebase console](https://console.firebase.google.com/project/_/functions). | ||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
|
@@ -87,7 +95,7 @@ interoperate well together. | |||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
### Redirects, Rewrites, and Headers | ||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
The {{firebase_cli}} respects | ||||||||||||||||||||||||||||||
The {{firebase_cli}} respects | ||||||||||||||||||||||||||||||
[redirects](https://nextjs.org/docs/api-reference/next.config.js/redirects), | ||||||||||||||||||||||||||||||
[rewrites](https://nextjs.org/docs/api-reference/next.config.js/rewrites), and | ||||||||||||||||||||||||||||||
[headers](https://nextjs.org/docs/api-reference/next.config.js/headers) in | ||||||||||||||||||||||||||||||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new caution message could be improved for better clarity and presentation.
>
) will make the caution message stand out more visually."graduating"
is a bit colloquial for technical documentation. "Migrating" or "moving" would be a more standard term.