-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[MCP] feat(dataconnect): dataconnect_build nows generate SDKs #9336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Adds a `generate_sdk` option to the `dataconnect_build` MCP tool. When `generate_sdk` is true, the tool generates typed SDKs for the Data Connect connectors by calling `DataConnectEmulator.generate`.
Summary of ChangesHello @fredzqm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant enhancement to the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a generate_sdk option to the dataconnect_build tool, allowing users to generate typed SDKs for Data Connect connectors. The implementation is straightforward, but there are a couple of areas for improvement. I've pointed out a potential runtime error due to a missing project ID and suggested adding a check to ensure projectId exists. Additionally, to improve the user experience, I've recommended checking whether any SDKs are configured for generation before executing the command, similar to how the dataconnect:sdk:generate command behaves. Addressing these points will make the new feature more robust and user-friendly.
Adds a
generate_sdkoption to thedataconnect_buildMCP tool. Whengenerate_sdkis true, the tool generates typed SDKs for the Data Connect connectors by callingDataConnectEmulator.generate.Description
Scenarios Tested
Sample Commands