feat(init): split hosting setup into askQuestions and actuate

[joehan]

Description

Refactors the hosting feature's doSetup function into askQuestions and actuate functions, following the pattern of other features like firestore and database.

This change separates user interaction from the actuation of changes, improving modularity and maintainability. It has no user facing effect yet, but it is step one of adding hosting to the init MCP tool.

Scenarios Tested

I ran through firebase init hosting, hitting both the standard flow and the nextjs web frameworks flow, and confirmed that they are still working as before.

[gemini-code-assist]

Summary of Changes

Hello @joehan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant refactoring to the Firebase Hosting initialization logic, segmenting the process into distinct phases for user interaction and the subsequent application of changes. This architectural improvement enhances the feature's modularity and maintainability, aligning it with best practices observed in other core Firebase services.

Highlights

• Refactored Hosting Setup: The doSetup function for Firebase Hosting has been split into askQuestions and actuate functions.
• Improved Modularity: This change separates user interaction from the actual implementation of changes, following patterns established by other features like Firestore and Database.
• Dependency Update: The globals package (version ^16.4.0) has been added to package.json.
• Data Structure Change: Hosting-related information is now stored under setup.featureInfo.hosting instead of directly under setup.hosting.
• Function Export Updates: The main features index and init process have been updated to correctly import and utilize the new askQuestions and actuate functions for hosting.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the hosting feature's doSetup function into askQuestions and actuate, which is a great improvement for modularity and follows the pattern of other features. The refactoring is well-executed, but I've identified a critical bug in the new actuate function where framework discovery uses an incorrect directory, potentially leading to data loss. I've also provided a suggestion to improve type safety by defining a new interface for hosting information, which addresses a TODO in the code. Lastly, there's a minor typo fix in an error message.

[joehan]

/gemini review

[gemini-code-assist]

Code Review

This pull request effectively refactors the hosting setup logic by splitting the doSetup function into askQuestions and actuate, aligning it with the pattern used by other features. This separation of concerns improves modularity and maintainability. The changes are well-contained and logical. I've found one bug related to non-interactive mode and one minor suggestion for improving code style and safety.