-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Removing support for .bolt rules #9339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @joehan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request fully deprecates and removes support for Firebase Bolt rules within the Firebase CLI tools. Given that Bolt was archived and effectively deprecated long ago, this change aligns the tooling by eliminating all parsing and processing logic for Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly removes support for the deprecated .bolt
rules format. The changes are well-contained, removing the parseBoltRules.ts
file and updating configurations and deployment scripts to throw an error when a .bolt
file is used. I have one suggestion to improve the error handling in the database emulator to make it consistent with the other changes and provide a better user experience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no strong opinions here -- but if we're no longer supporting it, removing it makes sense to me.
Description
Bolt was effectively deprecated long ago - we last made changes to firebase-bolt in 2018 (https://github.com/FirebaseExtended/bolt) and it was archived recently. I'd like to drop support for it in the next major version.