Skip to content

Conversation

joehan
Copy link
Contributor

@joehan joehan commented Oct 17, 2025

Description

Bolt was effectively deprecated long ago - we last made changes to firebase-bolt in 2018 (https://github.com/FirebaseExtended/bolt) and it was archived recently. I'd like to drop support for it in the next major version.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @joehan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request fully deprecates and removes support for Firebase Bolt rules within the Firebase CLI tools. Given that Bolt was archived and effectively deprecated long ago, this change aligns the tooling by eliminating all parsing and processing logic for .bolt files. Users attempting to deploy or use .bolt rules will now receive a clear error message, guiding them towards current security rule formats.

Highlights

  • Removal of Bolt Rules Support: All code paths related to parsing and handling .bolt rules files have been removed from the codebase.
  • Error Handling for Bolt Files: Attempting to use .bolt files will now result in a FirebaseError being thrown, explicitly stating that support for .bolt rules has been discontinued as of [email protected].
  • Deletion of parseBoltRules Utility: The dedicated src/parseBoltRules.ts file, which contained the logic for parsing Bolt rules, has been entirely removed.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes support for the deprecated .bolt rules format. The changes are well-contained, removing the parseBoltRules.ts file and updating configurations and deployment scripts to throw an error when a .bolt file is used. I have one suggestion to improve the error handling in the database emulator to make it consistent with the other changes and provide a better user experience.

Copy link
Contributor

@nguymichael nguymichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no strong opinions here -- but if we're no longer supporting it, removing it makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants