Skip to content

Conversation

@maneesht
Copy link
Contributor

@maneesht maneesht commented Oct 21, 2025

  • Added detection for firebase-admin apps using firebase-admin and firebase-functions dependencies

Note: this should not be merged in until the generated SDK has been merged

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @maneesht, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the application detection capabilities by adding support for Firebase Admin Node.js applications. It introduces a new platform type, updates the configuration schema, and implements the necessary logic to identify these applications based on their dependencies. This change allows for more accurate application recognition and tailored SDK generation for Firebase Admin projects.

Highlights

  • Firebase Admin Connector Detection: Introduced the ability to detect Firebase Admin Node.js applications based on the presence of firebase-admin or firebase-functions dependencies in package.json.
  • New Platform Type: Added a new ADMIN_NODE platform type to categorize detected Firebase Admin applications.
  • Schema and Type Definition Updates: Updated the connector-yaml.json schema and dataconnect/types.ts to include adminNodeSdk configuration options, allowing for specific settings like outputDir, package, and packageJsonDir.
  • SDK Generation Integration: Integrated the new adminNodeSdk into the SDK generation logic, ensuring that appropriate SDKs can be generated for Firebase Admin Node.js applications.
  • Comprehensive Testing: Added new unit tests to appUtils.spec.ts and sdk.spec.ts to validate the correct detection of ADMIN_NODE apps and the proper configuration of adminNodeSdk in the connector YAML.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@maneesht maneesht changed the title Added firebase admin connector Added admin app detection for fdc Oct 21, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for Firebase Admin Node SDKs in Data Connect, including schema updates, app detection logic for Node.js admin apps, and updates to the SDK generation and initialization flows. My review identifies a critical issue with a describe.only in a test file that would prevent other tests from running, a high-severity bug in the app detection logic that incorrectly misses web frameworks, and a few medium-severity issues related to performance, a misleading schema description, and a test name. Overall, the changes are good but the identified issues should be addressed.

@maneesht maneesht marked this pull request as draft October 21, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant