-
Couldn't load subscription status.
- Fork 1.1k
Added admin app detection for fdc #9360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @maneesht, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the application detection capabilities by adding support for Firebase Admin Node.js applications. It introduces a new platform type, updates the configuration schema, and implements the necessary logic to identify these applications based on their dependencies. This change allows for more accurate application recognition and tailored SDK generation for Firebase Admin projects. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for Firebase Admin Node SDKs in Data Connect, including schema updates, app detection logic for Node.js admin apps, and updates to the SDK generation and initialization flows. My review identifies a critical issue with a describe.only in a test file that would prevent other tests from running, a high-severity bug in the app detection logic that incorrectly misses web frameworks, and a few medium-severity issues related to performance, a misleading schema description, and a test name. Overall, the changes are good but the identified issues should be addressed.
firebase-adminapps usingfirebase-adminandfirebase-functionsdependenciesNote: this should not be merged in until the generated SDK has been merged