Skip to content

Conversation

@TrCaM
Copy link
Contributor

@TrCaM TrCaM commented Oct 23, 2025

Follow-up to #9185

When the orchestration API returns errors with detailed information (such as TOS requirements), the error
details including help links were not being logged to users.

This PR adds an error handler that:

  • Extracts and logs ErrorInfo (reason, domain) from API error responses
  • Displays help links with actionable URLs (e.g., TOS acceptance links)
  • Provides users with clear guidance on how to resolve issues

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @TrCaM, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the user experience when encountering errors during Firebase app provisioning. By introducing a dedicated error handling module, the system can now parse and present detailed error information, including specific reasons and actionable help links, directly from the orchestration API responses. This change ensures that users receive clear guidance on how to resolve issues, such as unaccepted Terms of Service, rather than generic error messages.

Highlights

  • Detailed Error Logging: Implemented a new error handler function, logProvisioningError, to extract and log structured error details (reason, domain, metadata) and actionable help links from Google RPC API responses embedded within FirebaseError contexts.
  • Enhanced Error Messaging: Introduced enhanceProvisioningError which wraps raw errors with a user-friendly context message, ensuring that detailed error information is logged before presenting a concise error to the user.
  • Improved User Guidance: Errors originating from the orchestration API, such as those related to Terms of Service (TOS) requirements, will now display specific reasons and actionable URLs, providing clear guidance for users to resolve issues.
  • Centralized Error Handling: Refactored the provisionFirebaseApp function to utilize the new enhanceProvisioningError for consistent and informative error reporting during Firebase app provisioning.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a valuable enhancement by adding a dedicated error handler to log detailed information from orchestration API responses, which will significantly improve the debugging experience. The new logic is well-encapsulated and accompanied by a comprehensive set of tests. I have a couple of suggestions to further improve the robustness of the error handling and the readability of the logged output.

@TrCaM TrCaM requested a review from joehan October 23, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant