-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix: Include detailed error information from orchestration API responses #9377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…orchestration API's integration
Summary of ChangesHello @TrCaM, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the user experience when encountering errors during Firebase app provisioning. By introducing a dedicated error handling module, the system can now parse and present detailed error information, including specific reasons and actionable help links, directly from the orchestration API responses. This change ensures that users receive clear guidance on how to resolve issues, such as unaccepted Terms of Service, rather than generic error messages. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a valuable enhancement by adding a dedicated error handler to log detailed information from orchestration API responses, which will significantly improve the debugging experience. The new logic is well-encapsulated and accompanied by a comprehensive set of tests. I have a couple of suggestions to further improve the robustness of the error handling and the readability of the logged output.
Follow-up to #9185
When the orchestration API returns errors with detailed information (such as TOS requirements), the error
details including help links were not being logged to users.
This PR adds an error handler that: