-
Notifications
You must be signed in to change notification settings - Fork 1.1k
working progress of mcp server registry #9491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @charlotteliang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request establishes the initial configuration for a Model Context Protocol (MCP) server tailored for Firebase integration. It lays the groundwork by defining the server's metadata, its purpose in connecting AI development tools with Firebase, and its associated package details within a new Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a server registry file for the MCP (Model Context Protocol) server. This file is intended to provide metadata about the server for discovery by clients. My review focused on the consistency of this new file with the existing server implementation. I've identified a version mismatch between the registry and the server code that could lead to issues and should be corrected.
| { | ||
| "$schema": "https://static.modelcontextprotocol.io/schemas/2025-10-17/server.schema.json", | ||
| "name": "io.github.firebase/firebase-mcp", | ||
| "description": "A MCP server that provides AI development tools the ability to work with Firebase in your app.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"A MCP server" is redundant here. Maybe something like (stolen from the CLI extension page):
| "description": "A MCP server that provides AI development tools the ability to work with Firebase in your app.", | |
| "description": "Gives AI development tools Firebase-specific capabilities and expertise.", |
Adding server.json so that we can get the MCP listed on the MCP registry. The registry only allows us to hard code the version of the package to point to, so I also updated our release script to bump that version as we do (credit to Gemini for the shell script).
Following https://modelcontextprotocol.info/tools/registry/publishing/ as I go, this is steps 1-3
##Scenarios Tested
I manually tested out the update-server-json-version shell script, and it works correctly.