Remove legacy parseTriggers fallback for Node.js functions

firebase-vscode/webpack.common.js

@@ -196,13 +196,6 @@ const extensionConfig = {
           to: "./schema",
         },
         // TODO(hlshen): Sanity check if these should be fixed or removed. AFIACT, they exist for functions and hosting deploys, which are not relevant anymore.
-        // Copy uncompiled JS files called at runtime by
-        // firebase-tools/src/parseTriggers.ts
-        // {
-        //   from: "*.js",
-        //   to: "./",
-        //   context: "../src/deploy/functions/runtimes/node",
-        // },
         // // Copy cross-env-shell.js used to run predeploy scripts
         // // to ensure they work in Windows
         // {

package.json

@@ -263,7 +263,7 @@
     "source-map-support": "^0.5.9",
     "supertest": "^6.2.3",
     "swagger2openapi": "^7.0.8",
-    "ts-node": "^10.4.0",
+    "ts-node": "^10.9.2",
     "typescript": "^4.5.4",
     "typescript-json-schema": "^0.65.1",
     "vite": "^4.2.1"

src/deploy/functions/runtimes/node/discoverBuild.spec.ts

@@ -0,0 +1,49 @@
+import { expect } from "chai";
+import * as sinon from "sinon";
+
+import * as node from ".";
+import * as discovery from "../discovery";
+import { FirebaseError } from "../../../../error";
+
+const PROJECT_ID = "test-project";
+const PROJECT_DIR = "/some/path";
+const SOURCE_DIR = "/some/path/fns";
+
+describe("NodeDelegate", () => {
+  describe("discoverBuild", () => {
+    let sandbox: sinon.SinonSandbox;
+    let delegate: node.Delegate;
+    let detectFromYamlStub: sinon.SinonStub;
+
+    beforeEach(() => {
+      sandbox = sinon.createSandbox();
+      delegate = new node.Delegate(PROJECT_ID, PROJECT_DIR, SOURCE_DIR, "nodejs16");
+      detectFromYamlStub = sandbox.stub(discovery, "detectFromYaml");
+    });
+
+    afterEach(() => {
+      sandbox.restore();
+    });
+
+    it("should throw error if SDK version is invalid", async () => {
+      sandbox.stub(delegate, "sdkVersion").get(() => "invalid");
+
+      await expect(delegate.discoverBuild({}, {})).to.be.rejectedWith(FirebaseError, /Could not parse firebase-functions version/);
+    });
+
+    it("should throw error if SDK version is too old", async () => {
+      sandbox.stub(delegate, "sdkVersion").get(() => "3.19.0");
+
+      await expect(delegate.discoverBuild({}, {})).to.be.rejectedWith(FirebaseError, /You are using an old version of firebase-functions SDK/);
+    });
+
+    it("should proceed if SDK version is new enough", async () => {
+        sandbox.stub(delegate, "sdkVersion").get(() => "3.20.0");
+        detectFromYamlStub.resolves({ endpoints: {}, requiredAPIs: [], params: [] });
+
+        await delegate.discoverBuild({}, {});
+
+        expect(detectFromYamlStub).to.have.been.called;
+      });
+  });
+});

src/deploy/functions/runtimes/node/index.ts

@@ -23,7 +23,6 @@ import { DelegateContext } from "..";
 import * as supported from "../supported";
 import * as validate from "./validate";
 import * as versioning from "./versioning";
-import * as parseTriggers from "./parseTriggers";
 import { fileExistsSync } from "../../../../fsutils";
 
 // The versions of the Firebase Functions SDK that added support for the container contract.
@@ -292,18 +291,15 @@ export class Delegate {
     env: backend.EnvironmentVariables,
   ): Promise<build.Build> {
     if (!semver.valid(this.sdkVersion)) {
-      logger.debug(
-        `Could not parse firebase-functions version '${this.sdkVersion}' into semver. Falling back to parseTriggers.`,
+      throw new FirebaseError(
+        `Could not parse firebase-functions version '${this.sdkVersion}' into semver. Please make sure you are using a valid version of firebase-functions.`,
       );
-      return parseTriggers.discoverBuild(this.projectId, this.sourceDir, this.runtime, config, env);
     }
     if (semver.lt(this.sdkVersion, MIN_FUNCTIONS_SDK_VERSION)) {
-      logLabeledWarning(
-        "functions",
+      throw new FirebaseError(
         `You are using an old version of firebase-functions SDK (${this.sdkVersion}). ` +
           `Please update firebase-functions SDK to >=${MIN_FUNCTIONS_SDK_VERSION}`,
       );
-      return parseTriggers.discoverBuild(this.projectId, this.sourceDir, this.runtime, config, env);
     }
     // Perform a check for the minimum SDK version that added annotation support for the `Build.extensions` property
     // and log to the user explaining why they need to upgrade their version.