feat(firebaseai): handle unknown parts when parsing content #17522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cynthiajoan
changed the title
MichaelVerdon
approved these changes
Aug 1, 2025
russellwheatley
requested changes
Aug 1, 2025
| @@ -81,7 +83,14 @@ Content parseContent(Object jsonObject) { | |||
|
|
|||
| /// Parse the [Part] from json object. | |||
| Part parsePart(Object? jsonObject) { | |||
| if (jsonObject is Map && jsonObject.containsKey('functionCall')) { | |||
| if (jsonObject is! Map<String, Object?>) { | |||
| log('Unhandled part format: $jsonObject'); | |||
There was a problem hiding this comment.
are the logs necessary if returning the unknown part?
There was a problem hiding this comment.
Yes, since this is backend added some new feature / Part data that the client SDK might not able to catch up, which is an abnormal case. We would like this information is delivered to developers and the client SDKs would like to catch up the new features going forward.
russellwheatley
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?