Skip to content

fix(remote_config, android): make onCancel accept nullable arguments to avoid crash on hot restart #17569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2025
Merged

fix(remote_config, android): make onCancel accept nullable arguments to avoid crash on hot restart #17569

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ain/kotlin/io/flutter/plugins/firebase/firebaseremoteconfig/FirebaseRemoteConfigPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,9 +206,9 @@ class FirebaseRemoteConfigPlugin
})
}

override fun onCancel(arguments: Any) {
override fun onCancel(arguments: Any?) {
// arguments will be null on hot restart, so we will clean up listeners in didReinitializeFirebaseCore()
val argumentsMap = arguments as Map<String, Any>
val argumentsMap = arguments as? Map<String, Any>
?: return
val appName = Objects.requireNonNull(argumentsMap["appName"]) as String

Expand Down
Loading