Skip to content

fix: throw error with duplicate action key #3021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gioboa
Copy link
Contributor

@gioboa gioboa commented Jun 3, 2025

This commit change the behavior with actions with the same name.
Based on the issue description I changed warnings into errors.

Close #26

Checklist (if applicable):

@gioboa gioboa changed the title feat: throw error with duplicate action key fix: throw error with duplicate action key Jun 3, 2025
@MichaelDoyle
Copy link
Member

Hey @gioboa - just checking - it looks like this PR only changes the "log level" from warning to error, and does not actually raise any error. Based on the PR title, though, I think you intend to throw an error?

@gioboa
Copy link
Contributor Author

gioboa commented Jul 7, 2025

Hey @gioboa - just checking - it looks like this PR only changes the "log level" from warning to error, and does not actually raise any error. Based on the PR title, though, I think you intend to throw an error?

Yep, you are right. I fixed the code to get the desired behavior.

@gioboa
Copy link
Contributor Author

gioboa commented Jul 23, 2025

Thanks for your review @MichaelDoyle
I'm looking forward to getting your feedback about the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Duplicate names in defineFlow overrides the original definition rather than failing.
2 participants