feat(go): update telemetry for compatibility with Firebase AIM #3264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eprovider if exists
…into jh-go-telemetry
huangjeff5
commented
Sep 4, 2025
Removed comment about getting context with span context.
huangjeff5
commented
Sep 4, 2025
Removed commented production handling notes for metrics.
huangjeff5
commented
Sep 4, 2025
Updated comment to reflect AIM compatibility for payload structure.
huangjeff5
force-pushed
the
jh-go-telemetry
branch
from
8825871 to
2e44fbc
Compare
apascal07
reviewed
Sep 4, 2025
apascal07
approved these changes
Sep 4, 2025
apascal07
changed the title
Added comments to clarify error handling for markedError.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metrics
(Will add thought metrics as a fast follow; they were added recently and don't want to keep exploding this PR)
Basic success flow
Error flow
Substep flow
Tool flow
(The Tool View looks slightly different because our tool loop inside the Generate() call is implemented slightly differently, that requires some more refactoring if we want the views to look exactly the same)