refactor(plugins/vertexai): migrate to v2 API #3487
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cabljac
reviewed
Aug 28, 2025
cabljac
reviewed
Aug 28, 2025
cabljac
reviewed
Aug 28, 2025
cabljac
reviewed
Aug 28, 2025
cabljac
reviewed
Aug 28, 2025
| @@ -370,13 +370,13 @@ export function defineVertexAIEmbedder( | |||
| // Text only embedder | |||
| instance = { | |||
| content: doc.text, | |||
| task_type: options?.taskType, | |||
| title: options?.title, | |||
| task_type: embedderRef.config?.taskType, | |||
There was a problem hiding this comment.
I'm not sure about reading from the embedderRef here?
Before we used options - i'm thinking at request time we could have these options specified which would take precedence over the config of the ref maybe
cabljac
force-pushed
the
@invertase/vertexai-migrate-v2-fixed
branch
from
cd7fedf to
480b59d
Compare
….com/firebase/genkit into @invertase/vertexai-migrate-v2-fixed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of issues still:
ai.embedalternative invector_search/indexers.tsai.embedManyalternative invector_search/retrievers.tsTodo: