infra: Remove ObjC quickstarts #1806
Conversation
Merge main
refactor(storage): Move storage qs to root of storage directory
fix(infra): Update scripts/test.sh to dynamically get scheme
This reverts commit 7f27d68.
fix(crashlytics): Rename test target's host app scheme
chore(rtdb): rename DatabaseExampleSwift to DatabaseExample
fix: Fail scripts/add_framework_script.rb if given target DNE
chore: Rename FIAM target from InAppMessagingExampleSwift to InAppMessagingExample
chore: Remove Swift suffix from installations
chore: Remove Swift suffix from fiam
The PerformanceExample UI tests were failing with a `UITargetAppPath should be provided` error. This was caused by the `TEST_TARGET_NAME` in the Xcode project being set to the product name (`PerformanceExampleSwift`) instead of the target name (`PerformanceExample`). Additionally, the main `test.sh` script is updated to only run the `sudo xcode-select` command during GitHub Actions, preventing sudo prompts during local execution and simplifying debugging.
chore: Remove Swift suffix from performance
Rename Perf references
chore: Rename more performance fixes
Summary of ChangesHello @ncooke3, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request undertakes a comprehensive cleanup and modernization of the Firebase iOS quickstarts. It removes all Objective-C examples, streamlining the project structure and reducing maintenance overhead. Concurrently, it updates project configurations to embrace modern Swift language features and dependency management through Swift Package Manager, ensuring the remaining Swift examples are up-to-date and leverage the latest platform capabilities. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is a significant and well-executed infrastructure update. It successfully removes legacy Objective-C quickstart examples across multiple projects, streamlining the repository. Additionally, it modernizes the remaining Swift projects by migrating them from CocoaPods to Swift Package Manager, which is a great improvement for dependency management. The changes also include valuable updates like adopting modern Swift syntax (e.g., @main), improving concurrency safety with @MainActor annotations, and replacing a third-party reachability library with Apple's native Network framework. The project files and schemes have been cleaned up consistently. Overall, these changes greatly improve the codebase's quality, maintainability, and modernity. I have not found any issues with the implementation.
| # TODO: Before merging into main, remove nc/quickstarts from all workflows. | ||
| branches: [ main, nc/quickstarts ] |
There was a problem hiding this comment.
| # TODO: Before merging into main, remove nc/quickstarts from all workflows. | |
| branches: [ main, nc/quickstarts ] | |
| branches: [ main ] |
| - '!abtesting/Design/**' | ||
| pull_request: | ||
| branches: [ main ] | ||
| branches: [ main, nc/quickstarts ] |
There was a problem hiding this comment.
| branches: [ main, nc/quickstarts ] | |
| branches: [ main ] |
| on: | ||
| push: | ||
| branches: [ main ] | ||
| branches: [ main, nc/quickstarts ] |
There was a problem hiding this comment.
| branches: [ main, nc/quickstarts ] | |
| branches: [ main ] |
| - 'scripts/analytics.sh' | ||
| pull_request: | ||
| branches: [ main ] | ||
| branches: [ main, nc/quickstarts ] |
There was a problem hiding this comment.
| branches: [ main, nc/quickstarts ] | |
| branches: [ main ] |
| on: | ||
| push: | ||
| branches: [ main ] | ||
| branches: [ main, nc/quickstarts ] |
There was a problem hiding this comment.
| branches: [ main, nc/quickstarts ] | |
| branches: [ main ] |
| - 'scripts/messaging.sh' | ||
| pull_request: | ||
| branches: [ main ] | ||
| branches: [ main, nc/quickstarts ] |
There was a problem hiding this comment.
| branches: [ main, nc/quickstarts ] | |
| branches: [ main ] |
| on: | ||
| push: | ||
| branches: [ main ] | ||
| branches: [ main, nc/quickstarts ] |
There was a problem hiding this comment.
| branches: [ main, nc/quickstarts ] | |
| branches: [ main ] |
| - '!performance/SwiftUIPerformanceQuickstart/PerformanceExample/Design/**' | ||
| pull_request: | ||
| branches: [ main ] | ||
| branches: [ main, nc/quickstarts ] |
There was a problem hiding this comment.
| branches: [ main, nc/quickstarts ] | |
| branches: [ main ] |
| - 'scripts/storage.sh' | ||
| pull_request: | ||
| branches: [ main ] | ||
| branches: [ main, nc/quickstarts ] |
There was a problem hiding this comment.
| branches: [ main, nc/quickstarts ] | |
| branches: [ main ] |
| on: | ||
| push: | ||
| branches: [ main ] | ||
| branches: [ main, nc/quickstarts ] |
There was a problem hiding this comment.
| branches: [ main, nc/quickstarts ] | |
| branches: [ main ] |
2 participants
Uh oh!
There was an error while loading. Please reload this page.