[FirebaseAI] Multimodal Attachment Preview Fix #1814
Conversation
Summary of ChangesHello @YoungHypo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue where multimodal attachment previews were not rendering correctly. It introduces a more robust and flexible preview mechanism by allowing each Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully fixes the multimodal attachment preview by implementing a custom previewView. Additionally, it updates the supported file extensions and MIME types to align with the Firebase AI documentation. While the UI fix is solid, the updates to file type handling have introduced a few issues. Specifically, support for the common .jpg extension has been dropped, there's an inconsistency in handling .pcm files, and a potentially incorrect mapping for .mpa files. I've provided detailed comments and suggestions to address these points.
| "pdf", "txt", "text", | ||
| // Images | ||
| "jpg", "jpeg", "png", "webp", | ||
| "png", "jpeg", "webp", |
There was a problem hiding this comment.
The .jpg file extension is missing from the list of supported image types. It's a very common extension for JPEG images and is listed in the official documentation you referenced. Please add it back to ensure .jpg files are supported.
| "png", "jpeg", "webp", | |
| "png", "jpeg", "jpg", "webp", |
There was a problem hiding this comment.
There is no jpg in https://firebase.google.com/docs/ai-logic/input-file-requirements?api=dev
| "flv", "mov", "mpeg", "mpegps", "mpg", "mp4", "webm", "wmv", "3gpp", | ||
| // Audio | ||
| "aac", "flac", "mp3", "m4a", "mpga", "mp4a", "opus", "pcm", "raw", "wav", "weba", | ||
| "aac", "flac", "mp3", "mpa", "mpeg", "mpga", "mp4", "opus", "pcm", "wav", "webm", |
There was a problem hiding this comment.
The pcm file extension is included in supportedFileExtensions, but the corresponding case in getMimeType to handle it has been removed. This inconsistency will lead to incorrect MIME type resolution for .pcm files. Since pcm is not listed in the official Firebase AI documentation, consider removing it from this set to avoid issues.
| "aac", "flac", "mp3", "mpa", "mpeg", "mpga", "mp4", "opus", "pcm", "wav", "webm", | |
| "aac", "flac", "mp3", "mpa", "mpeg", "mpga", "mp4", "opus", "wav", "webm", |
There was a problem hiding this comment.
| case "jpeg": | ||
| return "image/jpeg" |
There was a problem hiding this comment.
The case for .jpg files is missing. To properly handle .jpg files, which is a very common image extension, please add it back to this switch statement.
| case "jpeg": | |
| return "image/jpeg" | |
| case "jpeg", "jpg": | |
| return "image/jpeg" |
There was a problem hiding this comment.
There is no jpg in https://firebase.google.com/docs/ai-logic/input-file-requirements?api=dev
| public static let supportedFileExtensions: Set<String> = [ | ||
| // Documents / text | ||
| "pdf", "txt", "text", | ||
| // Images | ||
| "jpg", "jpeg", "png", "webp", | ||
| "png", "jpeg", "webp", | ||
| // Video | ||
| "flv", "mov", "qt", "mpeg", "mpg", "ps", "mp4", "webm", "wmv", "3gp", "3gpp", | ||
| "flv", "mov", "mpeg", "mpegps", "mpg", "mp4", "webm", "wmv", "3gpp", | ||
| // Audio | ||
| "aac", "flac", "mp3", "m4a", "mpga", "mp4a", "opus", "pcm", "raw", "wav", "weba", | ||
| "aac", "flac", "mp3", "mpa", "mpeg", "mpga", "mp4", "opus", "pcm", "wav", "webm", | ||
| // Documents | ||
| "pdf", "txt", | ||
| ] |
There was a problem hiding this comment.
The extensions mpeg, mp4, and webm are listed under both the Video and Audio sections. While using a Set correctly handles the duplicates, it makes the code harder to read and maintain. Consider listing each extension only once to improve clarity.
| case "mpa": | ||
| return "audio/m4a" |
There was a problem hiding this comment.
This mapping of the .mpa extension to the audio/m4a MIME type is potentially incorrect and confusing. The .mpa extension is typically for audio/mpeg, while .m4a is the extension for audio/m4a (MPEG-4 Audio). It seems you've replaced the .m4a case with .mpa but kept the audio/m4a MIME type. Please verify if this is the intended behavior.
1 participant
Problem
Broken preview flow: Current attachment preview card in MultimodalScreen did not show the custom card UI.
Fix
implemented
@ViewBuilderpublic funcpreviewView()inside MultimodalAttachment so each attachment supplies its own card (AttachmentPreview). This aligns with ConversationKit’s expectations. peterfriese/ConversationKit#20MIME conformance: I synced supportedFileExtensions and getMimeType with the official Firebase AI multimodal doc (image/video/audio/doc types now match the published list exactly). https://firebase.google.com/docs/ai-logic/input-file-requirements?api=dev