Skip to content

Conversation

@dtojikulov
Copy link

Pull Request Description

This PR fixes wrong typing of the response in /vault/accounts/:vaultAccountId/:assetId/addresses_paginated endpoint, particularly type property of the response. For some reason it was set as number in the sdk, but in docs it is string and in fact in the response the return type is string.
Screenshot attached with the response from the sandbox environment.

image

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Locally tested against Fireblocks API

Checklist:

  • I have performed a self-review of my own code
  • I have added corresponding labels to the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant