Add support for search queries in API v1 #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should also resolve #7 as it allows the default HTTP client to be configured It also adds cancellation of requests via a Context. |
|
There is issue with this change, the JSON unmarshal for Search response is giving error |
|
Hey @bmurray! Thanks a lot for your contribution to the repo—really appreciate it. I went ahead and added some tests and resolved the conflicts with main. Could you take a look when you have a moment? And sorry for the delay in reviewing your PR. I’ll be keeping a closer eye on this repo moving forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to v1, tested against a local Firecrawl server.