Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bumps the sdk to v1.8.4, which includes the addition of (among other things) support for Functionality properties including but not limited to
service_tier(which I -- and my organization -- need)I didn't change the CHANGELOG, but will be happy to do so. Just let me know what version you're targeting next.
Testing plan
I don't have a test FireHydrant account, so I'm going to have to lean on automated testing for this one, but I can say that the change didn't break any code (except for the one value that became a pointer, the sole reference to which I updated)
PR readiness
Edit: Tyop