feat: return exact timestamp when next action is required #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaseizinger
force-pushed
the
refactor/update-timers-at
branch
4 times, most recently
from
1a5d36a to
213d0e4
Compare
thomaseizinger
force-pushed
the
refactor/update-timers-at
branch
from
213d0e4 to
7674b90
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 16, 2025
At present, it is up to the host app how often it calls `update_timers_at`. Once a second should be enough but ideally, a `Tunn` just exposes when the next internal timer fires. This is being tackled more generally in #61. In order to ensure we send keep-alive messages in time, we incorporate `want_passive_keepalive_at` into the `next_timer_update` into it.
thomaseizinger
force-pushed
the
refactor/update-timers-at
branch
from
7674b90 to
33edc5f
Compare
thomaseizinger
force-pushed
the
refactor/update-timers-at
branch
from
33edc5f to
01d1757
Compare
thomaseizinger
force-pushed
the
refactor/update-timers-at
branch
from
01d1757 to
533419a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.