fix #4511 & #5137: when adding a child to a family, put it between older and younger children #5260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired on the algorithm of the 1.7 branch: put a new child after older children, just before the first child which is younger.
This saves the user from having to reorder or sort children after a child is added.
I did try to make some actual tests, avoid mocking everything, but alas got stuck on tree authorisations when creating a family or child.