Skip to content

Accommodate sprint removals in issue_enhanced #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fivetran-avinash merged 8 commits into from
Dec 9, 2025
Merged

Accommodate sprint removals in issue_enhanced #158

fivetran-avinash merged 8 commits into from
Dec 9, 2025

Conversation

@fivetran-jamie
Copy link
Contributor

@fivetran-jamie fivetran-jamie commented Nov 18, 2025 •
edited
Loading

PR Overview

Package version introduced in this PR:

  • 1.2.1-a1

This PR addresses the following Issue/Feature(s):

  • GA-1010242

Summary of changes:

  • Adjusts join in issue_sprint to be left instead of inner. This allows for truly null sprint assignments to persist through

Submission Checklist

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
      Validation tests fail on issue_enhanced when including sprint fields since this is fixing erroneous sprint assignments.
image

They pass when I exclude all sprint fields from issue_enhanced

  • Testing Instructions: Confirm the change addresses the issue(s) - customer testing
  • Focus Areas: Complex logic or queries that need extra attention
  • Merge any relevant open PRs into this PR

Changelog

  • Draft changelog for PR
  • Final changelog for release review

@fivetran-jamie fivetran-jamie marked this pull request as ready for review November 18, 2025 19:49
@fivetran-jamie fivetran-jamie self-assigned this Nov 18, 2025
@fivetran-jamie fivetran-jamie added the docs:ready Triggers the docs generator workflow. label Nov 19, 2025
@fivetran-jamie fivetran-jamie added the pre-release Triggers the auto-releaser workflow. label Nov 19, 2025
@fivetran-avinash fivetran-avinash changed the base branch from main to release/v1.3.1 December 8, 2025 19:53
@fivetran-avinash fivetran-avinash merged commit f19e78b into release/v1.3.1 Dec 9, 2025
0 of 2 checks passed
fivetran-avinash added a commit that referenced this pull request Dec 10, 2025
@fivetran-avinash @fivetran-jamie @github-actions
Release v1.3.1 (#161)
496a987 
* versioning

* Accommodate sprint removals in issue_enhanced (#158)

* Stage

* fix

* polish for pr

* remove vestigial code

* Generate dbt docs via GitHub Actions

* Merge conflicts

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Avinash Kunnath <[email protected]>
Co-authored-by: Avinash Kunnath <[email protected]>

* test updates (#160)

* test updates

* update integration_tests/dbt_project.yml

* update integration_tests/dbt_project.yml

* Schema

---------

Co-authored-by: Jamie Rodriguez <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@fivetran-jamie fivetran-jamie

Labels

docs:ready Triggers the docs generator workflow. pre-release Triggers the auto-releaser workflow.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fivetran-jamie @fivetran-avinash