Skip to content

Feature/sprint enhanced velocity report #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fivetran-avinash merged 9 commits into from
Apr 30, 2025
Merged

Feature/sprint enhanced velocity report #43

fivetran-avinash merged 9 commits into from
Apr 30, 2025

Conversation

@fivetran-avinash
Copy link
Contributor

@fivetran-avinash fivetran-avinash commented Mar 6, 2025 •
edited
Loading

PR Overview

This PR will address the following Issue/Feature: [#36] and dbt_jira #102

This PR will result in the following new package version: v0.8.0

So many new changes.

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Breaking Changes

  • Added the new is_active field to the following models so customers can more easily find active records.
    • stg_jira__issue_field_history
    • stg_jira__issue_multiselect_history
    • stg_jira__user

New Upstream Models: Sprint Reporting

  • We introduce new sprint reporting to the upstream package! This will help us examine high level sprint metrics, such as velocity, time tracking and story point completion. Customers should now be able to build valuable sprint visualizations, like their own velocity reports, estimation tracking, and goal metrics.

Documentation

  • Corrected references to connectors and connections in the README. (#42)

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Submission Checklist

Submitter:

  • Alignment meeting with the reviewer
  • Provide validation details:
    • Validation Steps: Outline how to verify the changes.

See the Height ticket

  • Testing Instructions: Clear steps for running/testing (e.g., scripts, sample data)

See Hex workbook linked in the Height ticket

  • Focus Areas: Highlight any complex logic or queries needing special attention

Reviewer:

  • Confirm submission requirements are met

Changelog

  • Draft after PR approval

If you had to summarize this PR in an emoji, which would it be?

📿

@fivetran-joemarkiewicz fivetran-joemarkiewicz marked this pull request as ready for review April 29, 2025 15:25
fivetran-joemarkiewicz
fivetran-joemarkiewicz approved these changes Apr 29, 2025
View reviewed changes
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once we sort out the test error.

fivetran-avinash
fivetran-avinash commented Apr 29, 2025
View reviewed changes
Copy link
Contributor Author

@fivetran-avinash fivetran-avinash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-joemarkiewicz Ready for re-review!

fivetran-joemarkiewicz
fivetran-joemarkiewicz approved these changes Apr 30, 2025
View reviewed changes
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and no need to block approval, but there are a few changes to be made before release review. Please make the below changes or let me know if you have any questions. Once those are applied and docs regenerated, this will be good for release review!

CHANGELOG.md Outdated
# dbt_jira_source v0.8.0
[PR #43](https://github.com/fivetran/dbt_jira_source/pull/43) introduces the following changes:

**3 total changes • 3 possible breaking changes**
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically in this context the addition of the new is_active fields is not breaking (aka won't cause a disruption in a workflow). We can log these as non-breaking changes.

Suggested change
**3 total changes • 3 possible breaking changes**
**3 total changes • 0 possible breaking changes**

Copy link
Contributor Author

@fivetran-avinash fivetran-avinash Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

macros/get_issue_field_history_columns.sql Outdated
{"name": "issue_id", "datatype": dbt.type_int()},
{"name": "value", "datatype": dbt.type_string()}
{"name": "value", "datatype": dbt.type_string()},
{"name": "is_active", "datatype": "boolean"},
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove trailing comma.

Suggested change
{"name": "is_active", "datatype": "boolean"},
{"name": "is_active", "datatype": "boolean"}

Copy link
Contributor Author

@fivetran-avinash fivetran-avinash Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

macros/get_user_columns.sql
{"name": "time_zone", "datatype": dbt.type_string()},
{"name": "username", "datatype": dbt.type_string()}
{"name": "username", "datatype": dbt.type_string()},
{"name": "is_active", "datatype": "boolean"}
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed the is_active is added here as well as within the src_jira.yml, stg_jira.yml, and CHANGELOG; however, it's not in the stg_jira__user model. Is there a reason this wasn't added there?

If not, please add to the staging model.

Copy link
Contributor Author

@fivetran-avinash fivetran-avinash Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh geez. Added.

@fivetran-avinash fivetran-avinash linked an issue Apr 30, 2025 that may be closed by this pull request
[Feature] Jira Source Package - Field History "Is Active" support #36
Closed
4 tasks
fivetran-avinash
fivetran-avinash commented Apr 30, 2025
View reviewed changes
Copy link
Contributor Author

@fivetran-avinash fivetran-avinash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final changes applied, ready for release review.

fivetran-jamie
fivetran-jamie approved these changes Apr 30, 2025
View reviewed changes
Copy link
Contributor

@fivetran-jamie fivetran-jamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fivetran-avinash fivetran-avinash merged commit 9e01b33 into main Apr 30, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fivetran-jamie fivetran-jamie fivetran-jamie approved these changes

@fivetran-joemarkiewicz fivetran-joemarkiewicz fivetran-joemarkiewicz approved these changes

Assignees

@fivetran-avinash fivetran-avinash

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature] Jira Source Package - Field History "Is Active" support

3 participants

@fivetran-avinash @fivetran-jamie @fivetran-joemarkiewicz