Skip to content

update/property-attribution-extraction #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fivetran-catfritz merged 11 commits into from
Oct 7, 2025
Merged

update/property-attribution-extraction #54

fivetran-catfritz merged 11 commits into from
Oct 7, 2025

Conversation

@fivetran-catfritz
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz commented Sep 23, 2025 •
edited
Loading

PR Overview

Package version introduced in this PR:

  • v1.1.1

This PR addresses the following Issue/Feature(s):

  • GA-1006011

Summary of changes:

  • To handle changes to the property_attribution field JSON structure introduced in the September 2025 Fivetran Klaviyo release, updates the int_klaviyo__event_attribution model to handle both legacy and new structures
  • Ensures the property_attribution field is a string for parsing downstream by implementing the json_to_string macro to properly handle JSON columns across different warehouses

Submission Checklist

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
    • Testing Instructions: Confirm the change addresses the issue(s)
    • Focus Areas: Complex logic or queries that need extra attention
  • Merge any relevant open PRs into this PR

Changelog

  • Draft changelog for PR
  • Final changelog for release review

@fivetran-catfritz fivetran-catfritz marked this pull request as draft September 23, 2025 15:20
@fivetran-catfritz fivetran-catfritz added the docs:ready Triggers the docs generator workflow. label Sep 29, 2025
@fivetran-catfritz fivetran-catfritz added pre-release Triggers the auto-releaser workflow. and removed docs:ready Triggers the docs generator workflow. pre-release Triggers the auto-releaser workflow. labels Sep 29, 2025
fivetran-catfritz
fivetran-catfritz commented Oct 6, 2025
View reviewed changes
models/intermediate/int_klaviyo__event_attribution.sql Outdated
coalesce(
{{ fivetran_utils.json_parse('cleaned_event_attribution', ['relationships', 'attributed-event', 'data', 'id']) }},
{{ fivetran_utils.json_parse('cleaned_event_attribution', ['attributed_event_id']) }}
)as extracted_id_raw
Copy link
Contributor Author

@fivetran-catfritz fivetran-catfritz Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coalesce is for backwards compatibility

@fivetran-catfritz fivetran-catfritz marked this pull request as ready for review October 6, 2025 16:17
@fivetran-catfritz fivetran-catfritz self-assigned this Oct 6, 2025
fivetran-jamie
fivetran-jamie approved these changes Oct 7, 2025
View reviewed changes
Copy link
Contributor

@fivetran-jamie fivetran-jamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fivetran-catfritz fivetran-catfritz added the docs:ready Triggers the docs generator workflow. label Oct 7, 2025
@fivetran-catfritz fivetran-catfritz merged commit c4e95ff into main Oct 7, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fivetran-jamie fivetran-jamie fivetran-jamie approved these changes

Assignees

@fivetran-catfritz fivetran-catfritz

Labels

docs:ready Triggers the docs generator workflow.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fivetran-catfritz @fivetran-jamie