feature/api-v3-updates #27

fivetran-catfritz · 2025-08-26T22:07:18Z

PR Overview

Package version introduced in this PR:

v1.0.1

This PR addresses the following Issue/Feature(s):

GA-947205

Summary of changes:

API V3 updates

Submission Checklist

Alignment meeting with the reviewer (if needed)
- Timeline and validation requirements discussed
Provide validation details:
- Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
- Testing Instructions: Confirm the change addresses the issue(s)
- Focus Areas: Complex logic or queries that need extra attention
Merge any relevant open PRs into this PR

Changelog

Draft changelog for PR
Final changelog for release review

fivetran-catfritz · 2025-08-27T21:11:48Z

models/staging/src_reddit_ads.yml

-          - name: comment_downvotes
-            description: '{{ doc("comment_downvotes") }}'
-          - name: comment_upvotes
-            description: '{{ doc("comment_upvotes") }}'
-          - name: comments_page_views
-            description: '{{ doc("comments_page_views") }}'


These columns (and same in the other lines for these cols) only existed in the source and were never brought into staging.

fivetran-joemarkiewicz

@fivetran-catfritz thanks for making these updates. A few change requests before approving.

dbt_project.yml

CHANGELOG.md

integration_tests/dbt_project.yml

models/staging/src_reddit_ads.yml

fivetran-joemarkiewicz · 2025-08-28T15:32:05Z

dbt_project.yml

    account: "{{ source('reddit_ads', 'account') }}"
+    business_account: "{{ source('reddit_ads','business_account') }}"


Interestingly it doesn't look like either of these variables ultimately are ever used. However, for consistency and to retain the scope of these changes, no action/change required but found this interesting.

dbt_reddit_ads/models/staging/tmp/stg_reddit_ads__account_tmp.sql

Lines 3 to 8 in b8bb39b

{%- set business_account_or_account = 'business_account' if var('reddit_ads__using_business_account', True) else 'account' -%}

{{

fivetran_utils.union_data(

table_identifier=business_account_or_account,

database_variable='reddit_ads_database',

Interesting... I guess in general the union_data models don't use the vars?

…dbt_reddit_ads into feature/api-v3-updates merge

CHANGELOG.md

fivetran-catfritz

Thanks @fivetran-joemarkiewicz I have made the updates.

CHANGELOG.md

dbt_project.yml

fivetran-catfritz · 2025-08-28T21:52:52Z

dbt_project.yml

    account: "{{ source('reddit_ads', 'account') }}"
+    business_account: "{{ source('reddit_ads','business_account') }}"


Interesting... I guess in general the union_data models don't use the vars?

models/staging/src_reddit_ads.yml

fivetran-joemarkiewicz

Looks good with one CHANGELOG recommendation.

fivetran-joemarkiewicz · 2025-08-29T14:14:23Z

CHANGELOG.md

+| [stg_reddit_ads__account_conversions_report_tmp](https://fivetran.github.io/dbt_reddit_ads/#!/model/model.reddit_ads.stg_reddit_ads__account_conversions_report)<br>[stg_reddit_ads__ad_group_conversions_report_tmp](https://fivetran.github.io/dbt_reddit_ads/#!/model/model.reddit_ads.stg_reddit_ads__ad_group_conversions_report)<br>[stg_reddit_ads__ad_conversions_report_tmp](https://fivetran.github.io/dbt_reddit_ads/#!/model/model.reddit_ads.stg_reddit_ads__ad_conversions_report)<br>[stg_reddit_ads__campaign_conversions_report_tmp](https://fivetran.github.io/dbt_reddit_ads/#!/model/model.reddit_ads.stg_reddit_ads__campaign_conversions_report)<br>[stg_reddit_ads__campaign_country_conversions_report_tmp](https://fivetran.github.io/dbt_reddit_ads/#!/model/model.reddit_ads.stg_reddit_ads__campaign_country_conversions_report) | New Columns |  | `clicks`<br>`views` | Added to support API v3. Coalesced downstream with the deprecated columns `click_through_conversion_attribution_window_month` and `view_through_conversion_attribution_window_month`. |
+| [stg_reddit_ads__account_conversions_report_tmp](https://fivetran.github.io/dbt_reddit_ads/#!/model/model.reddit_ads.stg_reddit_ads__account_conversions_report)<br>[stg_reddit_ads__ad_group_conversions_report_tmp](https://fivetran.github.io/dbt_reddit_ads/#!/model/model.reddit_ads.stg_reddit_ads__ad_group_conversions_report)<br>[stg_reddit_ads__ad_conversions_report_tmp](https://fivetran.github.io/dbt_reddit_ads/#!/model/model.reddit_ads.stg_reddit_ads__ad_conversions_report)<br>[stg_reddit_ads__campaign_conversions_report_tmp](https://fivetran.github.io/dbt_reddit_ads/#!/model/model.reddit_ads.stg_reddit_ads__campaign_conversions_report)<br>[stg_reddit_ads__campaign_country_conversions_report_tmp](https://fivetran.github.io/dbt_reddit_ads/#!/model/model.reddit_ads.stg_reddit_ads__campaign_country_conversions_report) | Deprecated Columns | `click_through_conversion_attribution_window_month`<br>`view_through_conversion_attribution_window_month` |  | Coalesced downstream with the new columns `clicks` and `views`. |


I'd prefer we make the Note from the first section regarding the new columns to be it's own section for the non tmp models. My recommendation would be to have a new row for the non tmp staging models after the callout of the new fields in the tmp models and highlight the coalesce modification to the fields in the staging model.

…dbt_reddit_ads into feature/api-v3-updates merge

feature/api-v3-updates

b2ba266

fivetran-catfritz self-assigned this Aug 26, 2025

fivetran-catfritz added 9 commits August 26, 2025 17:28

update macros

43d7a2b

fix docs

4389041

fix docs & vars

5c5a7a1

fix docs

f1e3c9f

fix docs

18f1f9d

fix dispatch

e421750

update docs

754af45

update seeds

ae4c834

ym

1a6177b

fivetran-catfritz commented Aug 27, 2025

View reviewed changes

docs

5e41056

fivetran-catfritz added the docs:ready Triggers the docs generator workflow. label Aug 27, 2025

Generate dbt docs via GitHub Actions

d017e98

fivetran-joemarkiewicz self-requested a review August 28, 2025 15:01

fivetran-joemarkiewicz requested changes Aug 28, 2025

View reviewed changes

fivetran-catfritz added 3 commits August 28, 2025 10:53

updates

303e7ba

Merge branch 'feature/api-v3-updates' of https://github.com/fivetran/…

418f017

…dbt_reddit_ads into feature/api-v3-updates merge

changelog

7c1472e

fivetran-joemarkiewicz reviewed Aug 28, 2025

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

updates

6b6a9d6

fivetran-catfritz commented Aug 28, 2025

View reviewed changes

fivetran-catfritz added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Aug 28, 2025

updates

1caadac

fivetran-catfritz added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Aug 28, 2025

Generate dbt docs via GitHub Actions

6713537

fivetran-joemarkiewicz approved these changes Aug 29, 2025

View reviewed changes

fivetran-catfritz added 2 commits September 2, 2025 16:06

fix seeds & changelog

7329893

Merge branch 'feature/api-v3-updates' of https://github.com/fivetran/…

670795e

…dbt_reddit_ads into feature/api-v3-updates merge

fivetran-catfritz added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Sep 2, 2025

github-actions bot and others added 3 commits September 2, 2025 21:08

Generate dbt docs via GitHub Actions

f29e955

fix seeds

ebb13b1

Merge branch 'feature/api-v3-updates' of https://github.com/fivetran/…

060d94e

…dbt_reddit_ads into feature/api-v3-updates merge

fivetran-catfritz added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Sep 2, 2025

Generate dbt docs via GitHub Actions

c72e455

fivetran-catfritz merged commit 2bb2ba9 into main Sep 2, 2025
9 checks passed

		account: "{{ source('reddit_ads', 'account') }}"
		business_account: "{{ source('reddit_ads','business_account') }}"

	{%- set business_account_or_account = 'business_account' if var('reddit_ads__using_business_account', True) else 'account' -%}

	{{
	fivetran_utils.union_data(
	table_identifier=business_account_or_account,
	database_variable='reddit_ads_database',

		\| [stg_reddit_ads__account_conversions_report_tmp](https://fivetran.github.io/dbt_reddit_ads/#!/model/model.reddit_ads.stg_reddit_ads__account_conversions_report)<br>[stg_reddit_ads__ad_group_conversions_report_tmp](https://fivetran.github.io/dbt_reddit_ads/#!/model/model.reddit_ads.stg_reddit_ads__ad_group_conversions_report)<br>[stg_reddit_ads__ad_conversions_report_tmp](https://fivetran.github.io/dbt_reddit_ads/#!/model/model.reddit_ads.stg_reddit_ads__ad_conversions_report)<br>[stg_reddit_ads__campaign_conversions_report_tmp](https://fivetran.github.io/dbt_reddit_ads/#!/model/model.reddit_ads.stg_reddit_ads__campaign_conversions_report)<br>[stg_reddit_ads__campaign_country_conversions_report_tmp](https://fivetran.github.io/dbt_reddit_ads/#!/model/model.reddit_ads.stg_reddit_ads__campaign_country_conversions_report) \| New Columns \| \| `clicks`<br>`views` \| Added to support API v3. Coalesced downstream with the deprecated columns `click_through_conversion_attribution_window_month` and `view_through_conversion_attribution_window_month`. \|
		\| [stg_reddit_ads__account_conversions_report_tmp](https://fivetran.github.io/dbt_reddit_ads/#!/model/model.reddit_ads.stg_reddit_ads__account_conversions_report)<br>[stg_reddit_ads__ad_group_conversions_report_tmp](https://fivetran.github.io/dbt_reddit_ads/#!/model/model.reddit_ads.stg_reddit_ads__ad_group_conversions_report)<br>[stg_reddit_ads__ad_conversions_report_tmp](https://fivetran.github.io/dbt_reddit_ads/#!/model/model.reddit_ads.stg_reddit_ads__ad_conversions_report)<br>[stg_reddit_ads__campaign_conversions_report_tmp](https://fivetran.github.io/dbt_reddit_ads/#!/model/model.reddit_ads.stg_reddit_ads__campaign_conversions_report)<br>[stg_reddit_ads__campaign_country_conversions_report_tmp](https://fivetran.github.io/dbt_reddit_ads/#!/model/model.reddit_ads.stg_reddit_ads__campaign_country_conversions_report) \| Deprecated Columns \| `click_through_conversion_attribution_window_month`<br>`view_through_conversion_attribution_window_month` \| \| Coalesced downstream with the new columns `clicks` and `views`. \|

feature/api-v3-updates #27

feature/api-v3-updates #27

Uh oh!

Conversation

fivetran-catfritz commented Aug 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Overview

Submission Checklist

Changelog

Uh oh!

fivetran-catfritz Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fivetran-joemarkiewicz Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

fivetran-catfritz Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fivetran-catfritz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

fivetran-catfritz Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

Uh oh!

fivetran-joemarkiewicz Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fivetran-catfritz commented Aug 26, 2025 •

edited

Loading