Skip to content

Conversation

@fivetran-savage
Copy link
Contributor

PR Overview

Package version introduced in this PR:

  • 1.3.0

This PR addresses the following Issue/Feature(s):

Summary of changes:

  • Adds conversions, view_through_conversions, items, and value fields for customizable event variables such as leads and page_visits

Submission Checklist

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
    • Testing Instructions: Confirm the change addresses the issue(s)
    • Focus Areas: Complex logic or queries that need extra attention
  • Merge any relevant open PRs into this PR

Changelog

  • Draft changelog for PR
  • Final changelog for release review

@fivetran-savage fivetran-savage marked this pull request as ready for review December 16, 2025 19:49
@fivetran-savage fivetran-savage added the docs:ready Triggers the docs generator workflow. label Dec 18, 2025
Copy link
Contributor

@fivetran-jamie fivetran-jamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really great! See comments

@fivetran-savage fivetran-savage added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Dec 19, 2025
Copy link
Contributor

@fivetran-jamie fivetran-jamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fivetran-savage fivetran-savage merged commit 3454e98 into main Dec 19, 2025
9 checks passed
@fivetran-savage fivetran-savage deleted the feature/conversion_metrics_by_event branch December 19, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs:ready Triggers the docs generator workflow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants