bugfix/country-conversions-test #11
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
Package version introduced in this PR:
v0.4.1
This PR addresses the following Issue/Feature(s):
I noticed this failure in my Ad Reporting work here: fivetran/dbt_ad_reporting#144

After some minor digging, I realized it was because we didn't include
event_namein the uniqueness test for the newstg_reddit_ads__campaign_country_conversions_reporttable. We include event_name in other*_conversions_reportmodels.Summary of changes:
This PR includes aligns the test on
stg_reddit_ads__campaign_country_conversions_reportwith the other conversions report models by addingevent_nameto its grain.Submission Checklist
including
event_nameallows the test to passdbt teston prod, thendbt testusing this branch.Changelog