Skip to content

Conversation

@fivetran-jamie
Copy link
Contributor

@fivetran-jamie fivetran-jamie commented May 16, 2025

PR Overview

Package version introduced in this PR:
v0.4.1

This PR addresses the following Issue/Feature(s):

I noticed this failure in my Ad Reporting work here: fivetran/dbt_ad_reporting#144
image

After some minor digging, I realized it was because we didn't include event_name in the uniqueness test for the new stg_reddit_ads__campaign_country_conversions_report table. We include event_name in other *_conversions_report models.

Summary of changes:

This PR includes aligns the test on stg_reddit_ads__campaign_country_conversions_report with the other conversions report models by adding event_name to its grain.

Submission Checklist

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • Validation Steps:
      including event_name allows the test to pass
image
  • Testing Instructions: dbt test on prod, then dbt test using this branch.
  • Focus Areas: Nothin really

Changelog

  • Draft changelog for PR
  • Final changelog for release review

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fivetran-joemarkiewicz fivetran-joemarkiewicz changed the title working bugfix/country-conversions-test May 20, 2025
Copy link
Contributor

@fivetran-avinash fivetran-avinash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit 3b8ed0c into main May 21, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants