Properly handle list of approvers even if user doesn't exists anymore in Slack#139
Open
IvanVojtko wants to merge 1 commit intofivexl:mainfrom
Open
Properly handle list of approvers even if user doesn't exists anymore in Slack#139IvanVojtko wants to merge 1 commit intofivexl:mainfrom
IvanVojtko wants to merge 1 commit intofivexl:mainfrom
Conversation
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Member
|
@IvanVojtko thanks for the PR, will look into it tomorrow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not properly handled for group request access. It's correctly handled if we use find_approvers_in_slack instead of directly getting list from get_user_by_email which throws an exception when user is not found. This PR fixes #138
Note
Improves resilience of approver resolution for group access requests.
get_user_by_emailusage withslack_helpers.find_approvers_in_slackinsrc/group.pyunderDecisionReason.RequiresApprovalto avoid exceptions when users no longer exist in Slackbad_result_emojiwaiting_result_emojiWritten by Cursor Bugbot for commit 3756f68. This will update automatically on new commits. Configure here.