Skip to content

Add trivial instances for () and Void #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add trivial instances for () and Void #148

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
17fea6f
Add trivial instances for () and Void
Jan 10, 2025
b7e4ce9
Use absurd in ToForm Void instance
Jan 10, 2025
14a5f53
Add FromForm Void instance
Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Web/Internal/FormUrlEncoded.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,10 @@ class ToForm a where

instance ToForm Form where toForm = id

instance ToForm Void where toForm _ = Form HashMap.empty

instance ToForm () where toForm _ = Form HashMap.empty

instance (ToFormKey k, ToHttpApiData v) => ToForm [(k, v)] where
toForm = fromList . map (toFormKey *** toQueryParam)

Expand Down Expand Up @@ -413,6 +417,8 @@ class FromForm a where

instance FromForm Form where fromForm = pure

instance FromForm () where fromForm _ = Right ()

-- | _NOTE:_ this conversion is unstable and may result in different key order (but not values).
instance (FromFormKey k, FromHttpApiData v) => FromForm [(k, v)] where
fromForm = fmap (concatMap (\(k, vs) -> map ((,) k) vs)) . toEntriesByKey
Expand Down
2 changes: 1 addition & 1 deletion stack.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
resolver: lts-12.10
resolver: lts-23.3
packages:
- '.'
flags:
Expand Down