Skip to content

fix: refactor & resolve a subset of mypy issues#934

Closed
mhoff wants to merge 1 commit intomainfrom
feat-escaping-json-dot-notation
Closed

fix: refactor & resolve a subset of mypy issues#934
mhoff wants to merge 1 commit intomainfrom
feat-escaping-json-dot-notation

Conversation

@mhoff
Copy link
Collaborator

@mhoff mhoff commented Feb 18, 2026

Description

  • Briefly summarize your changes in a few bullet points (can and should correspond to CHANGELOG.md)
  • Relates to #XXX (insert issue number here), if there is a corresponding GH issue

Assignee

  • The changes adhere to the contribution guidelines
  • I have performed a self-review of my code
  • My changes generate no new warnings (e.g. flake8/mypy/pytest/...) other than deprecations

Documentation

Code Quality

  • Patch test coverage > 95% and does not decrease
  • New code uses correct & specific type hints

How did you verify that the changes work in practice?

  • List of (preferably easy reproducible) tests including OS

Reviewer


The rendered docs for this PR can be found here.

@mhoff mhoff force-pushed the feat-escaping-json-dot-notation branch 9 times, most recently from a856aaa to 6e80b1c Compare February 18, 2026 19:57
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2026

Codecov Report

❌ Patch coverage is 98.55072% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.13%. Comparing base (738d7dc) to head (59f536c).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
logprep/filter/lucene_filter.py 90.00% 1 Missing ⚠️
logprep/util/helper.py 96.29% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #934   +/-   ##
=======================================
  Coverage   96.12%   96.13%           
=======================================
  Files         217      217           
  Lines       14202    14221   +19     
=======================================
+ Hits        13652    13671   +19     
  Misses        550      550           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mhoff mhoff force-pushed the feat-escaping-json-dot-notation branch from 6e80b1c to 809e92f Compare February 19, 2026 10:15
@mhoff mhoff force-pushed the feat-escaping-json-dot-notation branch from 809e92f to 59f536c Compare February 19, 2026 10:22
@mhoff mhoff changed the title feat: allow escaping of json dot notation fix: refactor & resolve a subset of mypy issues Feb 19, 2026
@mhoff mhoff closed this Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants