Skip to content

fix: refactor & resolve a subset of mypy issues#936

Merged
mhoff merged 8 commits intomainfrom
fix-mypy-issues
Feb 19, 2026
Merged

fix: refactor & resolve a subset of mypy issues#936
mhoff merged 8 commits intomainfrom
fix-mypy-issues

Conversation

@mhoff
Copy link
Collaborator

@mhoff mhoff commented Feb 19, 2026

Description

  • refactor & resolve a subset of mypy issues

Assignee

  • The changes adhere to the contribution guidelines
  • I have performed a self-review of my code
  • My changes generate no new warnings (e.g. flake8/mypy/pytest/...) other than deprecations

Documentation

Code Quality

  • Patch test coverage > 95% and does not decrease
  • New code uses correct & specific type hints

How did you verify that the changes work in practice?

  • pytests

Reviewer


The rendered docs for this PR can be found here.

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2026

Codecov Report

❌ Patch coverage is 98.19277% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.16%. Comparing base (62308c3) to head (cbbbf69).

Files with missing lines Patch % Lines
logprep/filter/lucene_filter.py 93.33% 1 Missing ⚠️
logprep/ng/abc/processor.py 93.33% 1 Missing ⚠️
logprep/util/helper.py 96.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #936      +/-   ##
==========================================
+ Coverage   96.13%   96.16%   +0.02%     
==========================================
  Files         217      217              
  Lines       14220    14219       -1     
==========================================
+ Hits        13671    13674       +3     
+ Misses        549      545       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@kaya-david kaya-david left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I’ve left a few comments and questions.

Copy link
Collaborator

@kaya-david kaya-david left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, one small comment left.

Copy link
Collaborator

@kaya-david kaya-david left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! I’ve left a suggestion for improvement. 👍

@kaya-david kaya-david self-requested a review February 19, 2026 15:40
@mhoff mhoff merged commit 0e19175 into main Feb 19, 2026
23 checks passed
@mhoff mhoff deleted the fix-mypy-issues branch February 19, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants