OFAC non critical error fix #273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark results for
|
| Date (UTC) | 2024-12-07T20:23:59+00:00 |
| Commit | 9975332606c094b9d006e604be542b40db9ae5ab |
| Base SHA | e13d221d6433b63e477a7513f1c41c71c0ff1459 |
Significant changes
None
sukoneck
approved these changes
Dec 7, 2024
| const SIM_FAILED_SUBSTRING: &str = "simulation failed"; | ||
| /// Any error containing SIM_FAILED_SUBSTRING and any of SIM_FAILED_NON_CRITICAL_ERRORS is not critical so we should not stop block building. | ||
| const SIM_FAILED_NON_CRITICAL_ERRORS: &[&str] = &[ | ||
| "blacklisted address", // Generated block is good but contains a blacklisted address. This happens if we don't use an OFAC blacklist but the relay does. |
Contributor
There was a problem hiding this comment.
Nit:
Use kinder language.
Suggested change
| "blacklisted address", // Generated block is good but contains a blacklisted address. This happens if we don't use an OFAC blacklist but the relay does. | |
| "blocklisted address", // Generated block is good but contains a blocklisted address. This happens if we don't use an OFAC blocklist but the relay does. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This version considers the error from the relay "block rejected because of OFAC addresses" as non critical.
💡 Motivation and Context
Without this change, non OFAC compliant builders would stop building blocks after sending a non-OFAC block to a OFAC complaint relay (flashbot's!).
✅ I have completed the following steps:
make lintmake test