Add '/metrics' to commonPaths in auth middleware#1299
Draft
sthwang-metal wants to merge 1 commit intoflatcar:mainfrom
Draft
Add '/metrics' to commonPaths in auth middleware#1299sthwang-metal wants to merge 1 commit intoflatcar:mainfrom
sthwang-metal wants to merge 1 commit intoflatcar:mainfrom
Conversation
Collaborator
|
Thanks for the PR @sthwang-metal! Could you share a bit more about the use case you want to cover? Since If your Prometheus instance runs in the same private network (e.g., same VPC or Kubernetes cluster) as Nebraska:
To support this safely, could you please make it configurable (opt-in)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip Auth for /metrics endpoint
Currently can't the
/metricsendpoint without auth. This change makes this consistent with the middlewareSkipper configured here:nebraska/backend/pkg/server/server.go
Line 37 in 52c5f0e
How to use
Spin up nebraska and go to /metrics endpoint without auth (like with curl)
Testing done
[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.