Add option to show branch in PR title #332
Conversation
| head = "{}:{}".format(repo.owner.login, change.branch) | ||
| pr_message = ((change.body or "") + "\n\n" + DISCLAIMER).strip() | ||
|
|
||
| if branch_title: |
There was a problem hiding this comment.
or something like:
| if branch_title: | |
| if base not in ('master', 'beta'): |
There was a problem hiding this comment.
I personal prefer a argument, so the User can decide if he want it or not. There may be someone who uses f-e-d-c on the master and the beta branch and want to know, if a PR goes against the master or the beta branch.
|
I wonder if it could be more generic - instead of a boolean option determining whether or not to put branch name into PR title, use a string option with PR title template, with |
| change: CommittedChanges, | ||
| manifest_checker: manifest.ManifestChecker = None, | ||
| fork: t.Optional[bool] = None, | ||
| branch_title: t.Optional[bool] = None, |
There was a problem hiding this comment.
| branch_title: t.Optional[bool] = None, | |
| branch_title: bool = False, |
|
Is this still needed? Instead of having branch in the title, labels would be better I think. fedc as of yesterday supports setting PR labels. Also the base branch is included in the branches it creates |
|
I'm already using labels. The problem with labels is that they don't show up in Notifications. |
|
Ok so can you rebase and fix the conflict? IMO these minor things don't need be an argument and can be added by default to the title but if you prefer then it's ok. |
So just add it to the title when the branch is not master? |
|
You can add it even when it is master. There is no reason to special case a single branch. |
f-e-d-c is currently used by com.riverbankcomputing.PyQt.BaseApp on 3 different branches. Having the branch (e.g. 5.15-22.08 or 6.3) would make it possible to see which branch is targeted directly in the Notification or the PR list.
Note: This is currently not tested