Add ability to skip routing on a particular setRoute() call.#179
Open
andyburke wants to merge 1 commit intoflatiron:masterfrom
Open
Add ability to skip routing on a particular setRoute() call.#179andyburke wants to merge 1 commit intoflatiron:masterfrom
andyburke wants to merge 1 commit intoflatiron:masterfrom
Conversation
Contributor
Author
|
Any word on this? Is there something that doesn't meet your requirements for this patch? I'm willing to work with you on modifications. |
|
👍 to this. |
|
+1 |
1 similar comment
|
+1 |
|
+1. Surprised this isn't already supported. |
|
+1: I can see a less intrusive option being to call a skipNextRoute() method as a less intrusive alternative |
|
That would be very nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm submitting this pull request even though I'm not sure it's the proper solution. I'd like to be able to set the route without triggering routing in a specific case. I don't see any better way to accomplish that, but I'm open to suggestions on how this code could be improved.
As it stands, this code is fulfilling my need. I can do:
and routing will not fire for that particular setRoute() call.
Please let me know what you think of this change.