Skip to content

node: Update playwright browsers handler #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

node: Update playwright browsers handler #485

wants to merge 2 commits into from

Conversation

Beryesa
Copy link

@Beryesa Beryesa commented Aug 21, 2025

@Beryesa Beryesa requested a review from a team as a code owner August 21, 2025 06:53
@github-actions github-actions bot added the node label Aug 21, 2025
@Beryesa
Copy link
Author

Beryesa commented Aug 21, 2025 •
edited
Loading

As a side node, webkit is fixed at 2092 for ubuntu 20.04 in playwright, but it looks like the revisionOverrides is not checked when reading browsers.json
There's no more 20.04 zip in newer versions. What's the suggested way around updating those? Add another check? (Breaking right now)
aiohttp.client_exceptions.ClientResponseError: 404, message='The specified blob does not exist.', url='https://playwright.azureedge.net/builds/webkit/2203/webkit-ubuntu-20.04.zip'

I can bump it to 22.04 or 24.04 - should it be a separate pull request?

@Beryesa Beryesa changed the title node: Add chromium-headless-shell to playwright node: Update playwright browsers Aug 21, 2025
@Beryesa
Copy link
Author

Beryesa commented Aug 21, 2025

I added the webkit bump as per 5583608, but please review, thanks!

@Beryesa Beryesa changed the title node: Update playwright browsers node: Update playwright browsers handler Aug 21, 2025
@bbhtt
Copy link
Collaborator

bbhtt commented Aug 23, 2025

@refi64 please take a look.

refi64
refi64 reviewed Aug 26, 2025
View reviewed changes
node/flatpak_node_generator/providers/special.py
url_tp = 'https://playwright.azureedge.net/builds/chromium/%d/%s'
dl_file = 'chromium-linux.zip'
elif name == 'chromium-headless-shell':
# Shouldn't need the old scheme (didn't exist in 'browsers')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what the comment means, what's scheme exactly? is it the revision number checks? would be worth more explicitly outlining whatever this is referring to.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was referring to the Revision number scheme comment above in full chromium, such that it doesn't need to take the old google source into account, how may I word that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@refi64 refi64 refi64 left review comments

At least 0 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

node

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flatpak Node Generator Fails with ValueError: Unknown playwright browser chromium-headless-shell

3 participants

@Beryesa @bbhtt @refi64