Move locale migration after cleanup #592
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, module-level cleanup can remove locale symlinks that point to locale data installed by other modules. Closes flatpak#154
|
If you could, add some tests to https://github.com/flatpak/flatpak-builder/blob/main/tests/test-builder.sh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, module-level cleanup can remove locale symlinks that point to locale data installed by other modules.
Closes #154
I've tested this building an app, and for that at least, it seems to work. I haven't tried building a runtime though. There are two other calls to
builder_migrate_locale_dirs()that I haven't really investigated. One happens in init for all runtimes, and the other applies only to platforms.