builder-manifest: Run appstream-compose with no-partial-urls argument #652
+58
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbhtt
force-pushed
the
bbhtt/as-no-part-urls
branch
2 times, most recently
from
8aa56e5 to
40a7146
Compare
This could've been done with the libappstream API but since flatpak-builder has until now avoided linking to it, we continue the theme. It also matches the pattern in flatpak_version_check() The CLI output format has been stable for 8+ years, see [1] [2]. We prefer the library version incase of a mismatch as ultimately compose will run with the features offered by the library [1]: ximion/appstream@d83174a [2]: https://github.com/ximion/appstream/blob/56ecd0067495213a64f3a490cbbc030fcfd5b8f1/tools/appstreamcli.c#L1594-L1604
When 0.16.3 is available This is an alternative to flatpak#576 We check at runtime instead of build-time and downgrade instead of erroring. Checking at build time is insufficient as there is no guarantee flatpak-builder is run with the same appstream version it was compiled with. Ideally we want to compose with `--no-partial-urls` so a warning is printed if it is not found. `--no-partial-urls` makes the mirrored URLs in appstream catalogue data the full URL. So if `--mirror-screenshot-url=https://example.org/media` and the metainfo has `<screenshot><image>https://github.com/foobar.png</image></screenshot>` After composing with `--no-partial-urls`, it will become <screenshot><image>https://example.org/media/foobar.png</image></screenshot>` instead of `/media/foobar.png`. This is needed by Flathub and generally should be a standard requirement for any software store (to have a full working URL instead of a partial whatever-that-is).
bbhtt
force-pushed
the
bbhtt/as-no-part-urls
branch
from
40a7146 to
fba37bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits
Alternative to #576, closes #576
We can optionally pick up the meson/autotools bits from there, just to signal packagers that we ideally want >= 0.16.3 but then we have to bump CI or turn them into warnings.