Skip to content

Conversation

grabear
Copy link

@grabear grabear commented Feb 23, 2020

For this Work in Progress PR I implemented a solution for #163. I know that nobody here knows me, so I'll try to explain what I've done so far and what I intend to do.

  • I converted all of the files to lowercase.
  • I converted all underscores in the file names to dashes ("_" to "-")
  • Because of the varying ways that people have decided to set the g:colors_name variable, I decided to simply append the following to the end of each file for insurance:
#newline
let g:colors_name = "<file-name-stem>"
  • Removed GUI vim only themes (winter, spring, and manuscript)
  • Removed bugged theme (martin-krischik)
  • Resolved duplicate filenames and colors_name

After some discussion and approval of the above changes, I would like to add a few things:

  • A PR and Issue github template

  • A Contributing github template

  • Some editing of the README

  • WHat do you guys think about adding a plugin using https://vim.fandom.com/wiki/Switch_color_schemes?

  • I used the switch color schemes plugin that maps to the NextColor function in order to find the bugged schemes, but there's an issue where some elements from previous schemes persist in the proceeding themes after pressing F8. Is there any easy way to reset everything.

@grabear grabear requested review from flazz and zachgersh February 23, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant