Fixed UI bug with org logo on My Device page #34084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed display logic for the organization logo component on the 'My Device' page to prevent flickering.
juan-fdz-hawa
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #34084 +/- ##
==========================================
- Coverage 64.23% 64.23% -0.01%
==========================================
Files 2057 2057
Lines 206744 206784 +40
Branches 6767 6784 +17
==========================================
+ Hits 132805 132825 +20
- Misses 63525 63545 +20
Partials 10414 10414
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sgress454
reviewed
Oct 14, 2025
| {isLoadingHost ? ( | ||
| <Spinner /> | ||
| ) : ( | ||
| <OrgLogoIcon className="logo" src={orgLogoURL} /> |
There was a problem hiding this comment.
Do we not want to still back to FleetIcon if there's no logo URL?
There was a problem hiding this comment.
Should be fine, if no src is provided then the component goes through its onError handler which sets the source to a default fleet logo ([email protected]).
juan-fdz-hawa
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
sgress454
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed display logic for the organization logo component on the 'My Device' page to prevent flickering.
Related issue: Resolves #33136
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
Testing