feat(tidy3d): FXC-5198-design-plugin-using-any-simulation-types#3224
Open
marcorudolphflex wants to merge 1 commit intodevelopfrom
Open
feat(tidy3d): FXC-5198-design-plugin-using-any-simulation-types#3224marcorudolphflex wants to merge 1 commit intodevelopfrom
marcorudolphflex wants to merge 1 commit intodevelopfrom
Conversation
Contributor
Diff CoverageDiff: origin/develop...HEAD, staged and unstaged changes
Summary
|
tylerflex
approved these changes
Feb 3, 2026
Collaborator
tylerflex
left a comment
There was a problem hiding this comment.
This is great.
Remind me whether we already have the ability to web.run() datastructures containing WorkflowType? like if I do
web.run([1.0, WorkflowType, {'a': WorkflowType}]) I should get
[1.0, WorkflowDataType, {'a': WorkflowDataType}]? if so we can probably simplify a ton of the code in design.py to use this. right now it's all hard coded. It could be a follow up PR if needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we have the generic web.run() now , this PR refactors the design plugin to simplify the running and allow it to generalize to things like Mode and EME.
Note
Medium Risk
Broadens core batching/type-dispatch logic used by all design sweeps; while mostly type/generalization changes, incorrect workflow classification or data replacement could break existing sweep execution or task metadata handling.
Overview
DesignSpace.runnow treats the pre-function output as a genericWorkflowType(and correspondingWorkflowDataType) instead ofSimulation/SimulationData, allowing parameter sweeps/optimizations to automatically batch and run workflows likeModeSimulation,ModeSolver,EMESimulation, and component modelers.This refactor updates type checks, task-name/path extraction, and cost estimation to operate on the workflow unions, and updates the design plugin README plus tests (including a new mode-simulation sweep) by extending the emulated runner to return appropriate workflow data objects.
Written by Cursor Bugbot for commit 83706e0. This will update automatically on new commits. Configure here.