FXC-1530: add total current normalization to UniformCurrentSource#3236
Open
dmarek-flex wants to merge 1 commit intodevelopfrom
Open
FXC-1530: add total current normalization to UniformCurrentSource#3236dmarek-flex wants to merge 1 commit intodevelopfrom
dmarek-flex wants to merge 1 commit intodevelopfrom
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Contributor
Diff CoverageDiff: origin/develop...HEAD, staged and unstaged changes
Summary
|
dmarek-flex
force-pushed
the
dmarek/FXC-1530-current-source-normalization
branch
from
3a31f35 to
2348ec5
Compare
| >>> pt_source = UniformCurrentSource(size=(0,0,0), source_time=pulse, polarization='Ex') | ||
| """ | ||
|
|
||
| define_as_total_current: bool = pydantic.Field( |
Collaborator
There was a problem hiding this comment.
how about current_amplitude_definition: Literal["density", "total"] = "density" to read better?
weiliangjin2021
approved these changes
Feb 7, 2026
Collaborator
weiliangjin2021
left a comment
weiliangjin2021
left a comment
There was a problem hiding this comment.
Just a small comment on naming.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes the semantics and default behavior for lumped-port excitations by altering how source amplitudes are interpreted/scaled, which can shift RF simulation normalization results; overall scope is localized to current sources and port generation.
Overview
Adds a new
UniformCurrentSource.define_as_total_currentflag sosource_timecan be treated as an integrated total current (auto-scaled by cross-sectional area) rather than a current density, making injected current mesh/geometry-size independent.Plumbs the new field through the public JSON schemas (
Simulation.json,TerminalComponentModeler.json) and updates rectangular lumped S-matrix ports to enable total-current normalization by default when creating theirUniformCurrentSource.Written by Cursor Bugbot for commit 2348ec5. This will update automatically on new commits. Configure here.