Skip to content

Issue209 #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Issue209 #210

wants to merge 1 commit into from

Conversation

dgofman
Copy link

@dgofman dgofman commented Jun 18, 2019

No description provided.

@dgofman dgofman mentioned this pull request Jun 18, 2019
Open
flosch
flosch reviewed Dec 10, 2021
View reviewed changes
parser_expression.go
val, ok := expr.expr1.(*simpleExpression)
if ok && val.negate {
t1, err := val.term1.Evaluate(ctx)
if err == nil {
Copy link
Owner

@flosch flosch Dec 10, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if err != nil? Shouldn't this be handled somehow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flosch flosch flosch left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgofman @flosch