Skip to content

fix: Correct filename typo in GoogleMlKitSubjectionSegmentationPlugin.m #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 11, 2025
Merged

fix: Correct filename typo in GoogleMlKitSubjectionSegmentationPlugin.m #750

merged 3 commits into from
Mar 11, 2025

Conversation

Kojok120
Copy link
Contributor

related to #749

fbernaly
fbernaly requested changes Mar 11, 2025
View reviewed changes
Copy link
Collaborator

@fbernaly fbernaly left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this change and rename files to GoogleMlKitSubjectSegmentationPlugin.h and GoogleMlKitSubjectSegmentationPlugin.m

https://github.com/flutter-ml/google_ml_kit_flutter/tree/develop/packages/google_mlkit_subject_segmentation/ios/Classes

@Kojok120 Kojok120 requested a review from fbernaly March 11, 2025 18:12
@fbernaly fbernaly merged commit 2ee0550 into flutter-ml:develop Mar 11, 2025
2 checks passed
@Kojok120
Copy link
Contributor Author

@fbernaly @bensonarafat
Thank you for the review (and all the work you've put into this project)!

@Kojok120 Kojok120 deleted the fix_typo_subject_segmentation branch March 11, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbernaly fbernaly fbernaly approved these changes

+1 more reviewer

@bensonarafat bensonarafat bensonarafat approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kojok120 @fbernaly @bensonarafat