[espresso] Bump gradle plugin to 9.1.1#11552
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Code Review
This pull request updates the Android Gradle Plugin to version 9.1.1 and increments the package version to 0.4.0+25. Feedback indicates that this update is a breaking change for the build environment and requires a minor version bump to 0.5.0 to comply with semantic versioning, along with a matching update to the changelog header.
| repository: https://github.com/flutter/packages/tree/main/packages/espresso | ||
| issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+espresso%22 | ||
| version: 0.4.0+24 | ||
| version: 0.4.0+25 |
There was a problem hiding this comment.
Bumping the Android Gradle Plugin to a new major version (9.x) is a significant change that typically introduces new toolchain requirements, such as Gradle 9.0+ and JDK 21. This is considered a breaking change for the build environment of consumers. Per the semantic versioning principles followed in this repository (referencing the flutter/packages contribution guide), breaking changes for packages below 1.0.0 should increment the minor version.
version: 0.5.0References
- Code should follow the guidance and principles described in the flutter/packages contribution guide, which includes following semantic versioning for breaking changes. (link)
| @@ -1,3 +1,7 @@ | |||
| ## 0.4.0+25 | |||
81ed19b to
b93e133
Compare
Bumps com.android.tools.build:gradle from 8.13.1 to 9.1.1 in packages/espresso.